Skip to content

Conversation

Avital-Fine
Copy link
Contributor

Description

List of new commands:

  1. BLMPOP
  2. LMPOP
  3. BZMPOP
  4. ZMPOP

closes #1909, closes #1908, closes #1960 , closes #1978


Checklist

  • Does npm test pass with this change (including linting)?
  • Is the new or changed code fully tested?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?

@codecov-commenter
Copy link

codecov-commenter commented Apr 18, 2022

Codecov Report

Merging #2051 (118e8cd) into master (c473c5f) will decrease coverage by 0.90%.
The diff coverage is 60.52%.

❗ Current head 118e8cd differs from pull request most recent head daaf35a. Consider uploading reports for the commit daaf35a to get more accurate results

@@            Coverage Diff             @@
##           master    #2051      +/-   ##
==========================================
- Coverage   95.25%   94.34%   -0.91%     
==========================================
  Files         387      391       +4     
  Lines        3516     3555      +39     
  Branches      423      426       +3     
==========================================
+ Hits         3349     3354       +5     
- Misses         83      117      +34     
  Partials       84       84              
Impacted Files Coverage Δ
packages/client/lib/commands/BLMOVE.ts 100.00% <ø> (ø)
packages/client/lib/commands/LMOVE.ts 100.00% <ø> (ø)
...ckages/client/lib/commands/generic-transformers.ts 94.87% <28.57%> (-5.13%) ⬇️
packages/client/lib/commands/ZMPOP.ts 66.66% <66.66%> (ø)
packages/client/lib/commands/LMPOP.ts 75.00% <75.00%> (ø)
packages/client/lib/commands/BLMPOP.ts 80.00% <80.00%> (ø)
packages/client/lib/commands/BZMPOP.ts 80.00% <80.00%> (ø)
packages/client/lib/cluster/commands.ts 100.00% <100.00%> (ø)
packages/client/lib/commands/SINTERCARD.ts 50.00% <0.00%> (-50.00%) ⬇️
packages/client/lib/commands/ZINTERCARD.ts 50.00% <0.00%> (-50.00%) ⬇️
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c473c5f...daaf35a. Read the comment docs.

@leibale leibale merged commit b1a0b48 into master Apr 25, 2022
@leibale leibale deleted the BZMPOP_ZMPOP branch April 25, 2022 11:50
florian-schunk pushed a commit to florian-schunk/node-redis that referenced this pull request Jun 18, 2025
* Support new muilti pop commands

* remove .only

* clean code

* fix for 4558ec6

* fix tests

Co-authored-by: leibale <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants