The "Multi" function does not work with long strings

[slava-viktorov]

The "multi" function does not work with long strings. When adding commands with long strings, the promise will never end.
In this example, only one command will be executed.

import { createClient } from 'redis';
import fetch from 'node-fetch';

const getHtmlText = async (url) => {
  const res = await fetch(url);
  const text = res.text();
  return text;
};

(async () => {
  const client = createClient();

  client.on('error', (err) => console.log('Redis Client Error', err));

  await client.connect();

  const text = await getHtmlText('https://google.com');
  const commands = Array.from(Array(2).keys()).map((n) => (['set', `test:${n}`, text]));
  const multi = await client.multi();
  commands.forEach((command) => {
    multi.addCommand(command);
  });
  const results = await multi.execAsPipeline();
})()
  .then(() => {
    console.log('DONE')
  })
  .catch(console.error);

Environment:

• Node.js Version: v16.2.0
• Redis Server Version: 6.2.5
• Node Redis Version: 4.0.0-rc.2
• Platform: Manjaro

[leibale]

@slava-viktorov I've just tried to run this code, and I get the "DONE" log...

[slava-viktorov]

@slava-viktorov I've just tried to run this code, and I get the "DONE" log...

I tested the code on a VPS. I have a bug again. Here is my bash script for Ubuntu.

#!/bin/bash

sudo apt update
sudo apt upgrade -y

sudo apt-get install -y gcc g++ make

curl -fsSL https://deb.nodesource.com/setup_16.x | sudo -E bash -
sudo apt update
sudo apt-get install -y nodejs

curl https://packages.redis.io/gpg | sudo apt-key add -
echo "deb https://packages.redis.io/deb $(lsb_release -cs) main" | sudo tee /etc/apt/sources.list.d/redis.list
sudo apt-get update
sudo apt-get install -y redis

mkdir testRedis
cd testRedis

touch index.js
touch package.json

echo '
{
  "name": "test-redis",
  "version": "1.0.0",
  "main": "index.js",
  "license": "MIT",
  "type": "module"
}
' >> package.json

echo '
import { createClient } from "redis";
import fetch from "node-fetch";

const getHtmlText = async (url) => {
  const res = await fetch(url);
  const text = res.text();
  return text;
};

(async () => {
  const client = createClient();

  client.on("error", (err) => console.log("Redis Client Error", err));

  await client.connect();

  const text = await getHtmlText("https://google.com");
  const commands = Array.from(Array(2).keys()).map((n) => (["set", `test:${n}`, text]));
  console.log("keys: ", commands.map(([_, key, __]) => key).join(", "));
  const multi = await client.multi();
  commands.forEach((command) => {
    multi.addCommand(command);
  });
  const results = await multi.execAsPipeline();
})()
  .then(() => {
    console.log("DONE")
  })
  .catch(console.error);
' >> index.js

npm install -g yarn
yarn add redis@next
yarn add node-fetch

node index.js

[leibale]

@slava-viktorov I tried to run it in a docker run -it ubuntu, still works for me... :|
If you want, I would love to debug it with you and see what is going on.

[slava-viktorov]

@slava-viktorov I tried to run it in a docker run -it ubuntu, still works for me... :| If you want, I would love to debug it with you and see what is going on.

I created a server so that we could debug and sent the login to your email. I think the problem is in the linux kernel settings for the tick.

[leibale]

@slava-viktorov I found the bug!
Thanks for helping and providing a VM :)
I'll release a new RC with the fix soon, in the meantime you can clone the repo and build it for self-use:

git clone https://github.com/redis/node-redis
cd node-redis
npm i
npm run build