-
Notifications
You must be signed in to change notification settings - Fork 3.9k
Obtain multiple pipelines concurrently. high performance improvement #3331
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: c00603587 <[email protected]>
Codecov ReportPatch coverage:
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more Additional details and impacted files@@ Coverage Diff @@
## master #3331 +/- ##
============================================
- Coverage 67.06% 66.97% -0.09%
+ Complexity 4662 4657 -5
============================================
Files 263 263
Lines 15092 15101 +9
Branches 952 952
============================================
- Hits 10121 10114 -7
- Misses 4566 4578 +12
- Partials 405 409 +4
... and 4 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
The more cluster nodes , the greater improvement |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In general, I agree with this PR and also submitted some comments.
…, otherwise the await cannot be released Signed-off-by: c00603587 <[email protected]>
Co-authored-by: M Sazzadul Hoque <[email protected]>
Signed-off-by: c00603587 <[email protected]>
Signed-off-by: c00603587 <[email protected]>
@sazzad16 @chenshi5012 I made some modifications, mainly including:
|
@yangbodong22011 WDYT about merging this PR before your commit and start a new PR from your commit? |
sure, everything is back to the way it was. |
@yangbodong22011 Thank you |
Merged. Thank you @chenshi5012 for your contribution! |
multiple pipelines sync concurrently will improvement the performance under redis cluster model
A 5-node cluster, vertically representing the results from the same batch
Extraordinary Suggestion: Convert sync to multi-threaded execution, which can improve performance by about 80%