Skip to content

all: Refactor tests for idiomatic Go and minor improvements #3561

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 25, 2025
+4 −11
Merged

all: Refactor tests for idiomatic Go and minor improvements #3561

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
39a15a4
all: Refactor tests for idiomatic Go and minor improvements
12ya Oct 24, 2025
a6cbbea
maintnotifications/e2e/utils_test: Update variadic args type in print…
12ya Oct 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions doctests/cmds_hash_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,7 @@ func ExampleClient_hset() {

keys := make([]string, 0, len(res6))

for key, _ := range res6 {
for key := range res6 {
keys = append(keys, key)
}

Expand Down Expand Up @@ -186,7 +186,7 @@ func ExampleClient_hgetall() {

keys := make([]string, 0, len(hGetAllResult2))

for key, _ := range hGetAllResult2 {
for key := range hGetAllResult2 {
keys = append(keys, key)
}

Expand Down
4 changes: 2 additions & 2 deletions hset_benchmark_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,7 @@ func benchmarkHSETOperations(b *testing.B, rdb *redis.Client, ctx context.Contex
b.Fatalf("HSET operation failed: %v", err)
}
}
totalTimes = append(totalTimes, time.Now().Sub(startTime))
totalTimes = append(totalTimes, time.Since(startTime))
}

// Stop the timer to calculate metrics
Expand Down Expand Up @@ -164,7 +164,7 @@ func benchmarkHSETPipelined(b *testing.B, rdb *redis.Client, ctx context.Context
if err != nil {
b.Fatalf("Pipeline execution failed: %v", err)
}
totalTimes = append(totalTimes, time.Now().Sub(startTime))
totalTimes = append(totalTimes, time.Since(startTime))
}

b.StopTimer()
Expand Down
7 changes: 0 additions & 7 deletions maintnotifications/e2e/utils_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,13 +43,6 @@ func containsSubstring(s, substr string) bool {
return false
}

func min(a, b int) int {
if a < b {
return a
}
return b
}

func printLog(group string, isError bool, format string, args ...interface{}) {
_, filename, line, _ := runtime.Caller(2)
filename = filepath.Base(filename)
Expand Down
Loading