Mark node as loading in Cluster pipeline read #1034
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vmihailenco
force-pushed
the
fix/pipeline-make-node-as-loading
branch
from
440c131 to
1c2b596
Compare
theodesp
reviewed
May 25, 2019
cluster.go
Outdated
| err = cn.WithReader(c.opt.ReadTimeout, func(rd *proto.Reader) error { | ||
| return c.pipelineReadCmds(node, rd, cmds, failedCmds) | ||
| }) | ||
| if err == nil { |
Contributor
There was a problem hiding this comment.
If you return err anyway why don't you return it as it is?
| github.com/onsi/gomega v1.5.0 | ||
| ) | ||
|
|
||
| go 1.13 |
Contributor
There was a problem hiding this comment.
We don't really need that info as nothing changed here
Collaborator
Author
There was a problem hiding this comment.
This is what go mod does automatically - not going to fight it on this matter
vmihailenco
force-pushed
the
fix/pipeline-make-node-as-loading
branch
from
1c2b596 to
6238b8d
Compare
vmihailenco
added a commit
that referenced
this pull request
Mar 11, 2020
Mark node as loading in Cluster pipeline read
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1031