Fix permissions for config files and introduce entrypoint testing #451
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR attempts to address permissions and ownership issues in the Redis config and data directories, but only for simple, default cases where it's safe to assume we won't overwrite or alter user-specific files (e.g., if a user's home directory is mistakenly mounted). **Key Changes:** * Fixes config file and directory permissions when they are insufficient for server startup. * Introduces the `SKIP_FIX_PERMS` environment variable to completely skip permission fixes, if desired. * Introduces the `SKIP_DROP_PRIVS` environment variable to optionally disable privilege dropping. This is not recommended, but may be necessary for compatibility with older image versions. * Adds a comprehensive entrypoint test suite that simulates a wide range of real-world scenarios. **Breaking Change Notice:** Users who previously relied on automatic permission fixes in the data directory but have non-standard configurations (e.g., a custom `appendonlydir`) or unrelated files in the data volume may find that these fixes no longer apply. We've chosen to err on the side of caution to avoid unintended data loss or misconfiguration caused by overly aggressive permission handling. Fixes: redis#446
Peter-Sh
force-pushed
the
RED-159320_fix_permissions
branch
from
464631a to
d5a41c5
Compare
adobrzhansky
approved these changes
May 29, 2025
adamiBs
pushed a commit
to adamiBs/docker-library-redis
that referenced
this pull request
Jun 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #446
This PR attempts to address permissions and ownership issues in the Redis config and data directories, but only for simple, default cases where it's safe to assume we won't overwrite or alter user-specific files (e.g., if a user's home directory is mistakenly mounted).
Key Changes:
SKIP_FIX_PERMSenvironment variable to completely skip permission fixes, if desired.SKIP_DROP_PRIVSenvironment variable to optionally disable privilege dropping. This is not recommended, but may be necessary for compatibility with older image versions.Breaking Change Notice:
Users who previously relied on automatic permission fixes in the data directory but have non-standard configurations (e.g., a custom
appendonlydir) or unrelated files in the data volume may find that these fixes no longer apply. We've chosen to err on the side of caution to avoid unintended data loss or misconfiguration caused by overly aggressive permission handling.