Skip to content

Fix nested batch issue when initial command is within a pipeline #402

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 24, 2025
Merged

Fix nested batch issue when initial command is within a pipeline #402

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
35c3d4f
fix nested batch issue when initial command is within a pipeline
atakavci Mar 21, 2025
7e154a8
Merge branch 'master' into ali/nested_batches
atakavci Mar 21, 2025
cae7d13
Merge branch 'master' into ali/nested_batches
atakavci Mar 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/NRedisStack/Pipeline.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ public class Pipeline
{
public Pipeline(IDatabase db)
{
db.SetInfoInPipeline();
_batch = db.CreateBatch();
}

Expand Down
18 changes: 18 additions & 0 deletions tests/NRedisStack.Tests/PipelineTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -156,4 +156,22 @@ public void TestJsonPipeline(string endpointId)
Assert.True(setResponse.Result);
Assert.Equal("{\"Name\":\"Shachar\",\"Age\":23}", getResponse.Result.ToString());
}

[SkippableTheory]
[MemberData(nameof(EndpointsFixture.Env.StandaloneOnly), MemberType = typeof(EndpointsFixture.Env))]
[Obsolete]
public async void Issue401_TestPipelineAsInitialCommand(string endpointId)
{
IDatabase db = GetCleanDatabase(endpointId);

Auxiliary.ResetInfoDefaults(); // demonstrate first connection
var pipeline = new Pipeline(db);

var setTask = pipeline.Json.SetAsync("json-key", "$", "{}");
_ = pipeline.Db.KeyExpireAsync(key, TimeSpan.FromSeconds(10));

pipeline.Execute();

Assert.True(await setTask);
}
}
Loading