Skip to content

Fix failing tests for CLIENT INFO on 8.0 #382

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jan 25, 2025
Merged

Fix failing tests for CLIENT INFO on 8.0 #382

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
7b05b5c
fix failing tests for CLIENT INFO on 8.0M2
atakavci Jan 23, 2025
0f2a90a
Merge branch 'master' into ali/fix_for_8.0-M
atakavci Jan 23, 2025
be3849b
Merge branch 'master' into ali/fix_for_8.0-M
atakavci Jan 23, 2025
eccfdd6
Merge branch 'master' into ali/fix_for_8.0-M
atakavci Jan 24, 2025
4247932
Merge branch 'master' into ali/fix_for_8.0-M
atakavci Jan 24, 2025
90a116b
Merge branch 'master' into ali/fix_for_8.0-M
atakavci Jan 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions tests/NRedisStack.Tests/Core Commands/CoreTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ public void TestSimpleSetInfo(string endpointId)
db.ClientSetInfo(SetInfoAttr.LibraryVersion, "1.2.3");

var info = db.Execute("CLIENT", "INFO").ToString();
Assert.EndsWith($"lib-name=TestLibraryName lib-ver=1.2.3\n", info);
Assert.Contains($"lib-name=TestLibraryName lib-ver=1.2.3", info);
}

[SkipIfRedis(Is.Enterprise, Comparison.LessThan, "7.1.242")]
Expand All @@ -38,7 +38,7 @@ public async Task TestSimpleSetInfoAsync(string endpointId)
await db.ClientSetInfoAsync(SetInfoAttr.LibraryVersion, "1.2.3");

var info = db.Execute("CLIENT", "INFO").ToString();
Assert.EndsWith($"lib-name=TestLibraryName lib-ver=1.2.3\n", info);
Assert.Contains($"lib-name=TestLibraryName lib-ver=1.2.3", info);
}

[SkipIfRedis(Is.Enterprise, Comparison.LessThan, "7.1.242")]
Expand All @@ -51,7 +51,7 @@ public void TestSetInfoDefaultValue(string endpointId)
db.Execute(new SerializedCommand("PING")); // only the extension method of Execute (which is used for all the commands of Redis Stack) will set the library name and version.

var info = db.Execute("CLIENT", "INFO").ToString();
Assert.EndsWith($"lib-name=NRedisStack(.NET_v{Environment.Version}) lib-ver={GetNRedisStackVersion()}\n", info);
Assert.Contains($"lib-name=NRedisStack(.NET_v{Environment.Version}) lib-ver={GetNRedisStackVersion()}", info);
}

[SkipIfRedis(Is.Enterprise, Comparison.LessThan, "7.1.242")]
Expand All @@ -64,7 +64,7 @@ public async Task TestSetInfoDefaultValueAsync(string endpointId)
await db.ExecuteAsync(new SerializedCommand("PING")); // only the extension method of Execute (which is used for all the commands of Redis Stack) will set the library name and version.

var info = (await db.ExecuteAsync("CLIENT", "INFO")).ToString();
Assert.EndsWith($"lib-name=NRedisStack(.NET_v{Environment.Version}) lib-ver={GetNRedisStackVersion()}\n", info);
Assert.Contains($"lib-name=NRedisStack(.NET_v{Environment.Version}) lib-ver={GetNRedisStackVersion()}", info);
}

[SkipIfRedis(Is.Enterprise, Comparison.LessThan, "7.1.242")]
Expand All @@ -77,7 +77,7 @@ public void TestSetInfoWithValue(string endpointId)
db.Execute(new SerializedCommand("PING")); // only the extension method of Execute (which is used for all the commands of Redis Stack) will set the library name and version.

var info = db.Execute("CLIENT", "INFO").ToString();
Assert.EndsWith($"NRedisStack(MyLibraryName;v1.0.0;.NET_v{Environment.Version}) lib-ver={GetNRedisStackVersion()}\n", info);
Assert.Contains($"NRedisStack(MyLibraryName;v1.0.0;.NET_v{Environment.Version}) lib-ver={GetNRedisStackVersion()}", info);
}

[SkipIfRedis(Is.Enterprise, Comparison.LessThan, "7.1.242")]
Expand All @@ -90,7 +90,7 @@ public async Task TestSetInfoWithValueAsync(string endpointId)
await db.ExecuteAsync(new SerializedCommand("PING")); // only the extension method of Execute (which is used for all the commands of Redis Stack) will set the library name and version.

var info = (await db.ExecuteAsync("CLIENT", "INFO")).ToString();
Assert.EndsWith($"NRedisStack(MyLibraryName;v1.0.0;.NET_v{Environment.Version}) lib-ver={GetNRedisStackVersion()}\n", info);
Assert.Contains($"NRedisStack(MyLibraryName;v1.0.0;.NET_v{Environment.Version}) lib-ver={GetNRedisStackVersion()}", info);
}

[SkipIfRedis(Is.Enterprise, Comparison.LessThan, "7.1.242")]
Expand Down
Loading