Skip to content

Conversation

@jopit
Copy link
Collaborator

@jopit jopit commented Nov 1, 2024

What type of PR is this?

/kind failing-test

What does this PR do / why we need it:

Fixes race condition in e2e test 1-052_validate_rolebinding_number. As per Jonathan's request:

  • '02-check_rolebindings.yaml' should loop wait, rather than only running once then failing:
    • first it should loop, waiting for the expected number of rolebindings exist (e.g. similar to an 'Eventually' in ginkgo)
    • then it should loop, waiting that the expected number of rolebindings continue to exists for 20 seconds (similar to 'Consistently' in ginkgo)

@openshift-ci openshift-ci bot requested review from sbose78 and svghadi November 1, 2024 18:27
@openshift-ci
Copy link

openshift-ci bot commented Nov 1, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from jopit. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jopit
Copy link
Collaborator Author

jopit commented Nov 1, 2024

/retest

1 similar comment
@jopit
Copy link
Collaborator Author

jopit commented Nov 4, 2024

/retest

@jgwest
Copy link
Member

jgwest commented Nov 5, 2024

Cluster init failure

/retest

Copy link
Member

@jgwest jgwest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @jopit!

@jgwest jgwest merged commit 4e70ae9 into redhat-developer:master Nov 6, 2024
22 of 23 checks passed
varshab1210 pushed a commit to nmirasch/gitops-operator that referenced this pull request Jul 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants