Skip to content

Conversation

@jiridanek
Copy link
Member

@jiridanek jiridanek commented Aug 18, 2025

Follow up on

Without it, Gemini goes into existential crisis

Okay, I will start by gathering the PR information.Got it. Repository is red-hat-data-services/notebooks. Now, fetching PR data.Okay, repository is known. PR data is missing. Getting changed files now.Okay, I have the repo owner and name. PR data and files are empty. Getting the PR number now.I have the repo owner/name, but no PR data, changed files, or PR number. I'll try fetching the diff, but without a PR number, I doubt it will work. I'm missing key information for a review.I have the repo owner and name, but no PR data, changed files, number, or instructions. I'll try gh pr diff "" to get the diff, but I expect it to fail. If it does, I'll notify the user that I can't proceed.I've followed all instructions to gather PR info, but everything's empty except the repository. The environment variables seem unset, preventing me from proceeding with the review. I'm stuck: I can't perform a review without data, but I'm also told not to ask for it. I'll try one last thing: gh pr list to see if I can
Okay, I will start by gathering the PR information.Got it. Repository is red-hat-data-services/notebooks. Now, fetching PR data.Okay, repository is known. PR data is missing. Getting changed files now.Okay, I have the repo owner and name. PR data and files are empty. Getting the PR number now.I have the repo owner/name, but no PR data, changed files, or PR number. I'll try fetching the diff, but without a PR number, I doubt it will work. I'm missing key information for a review.I have the repo owner and name, but no PR data, changed files, number, or instructions. I'll try gh pr diff "" to get the diff, but I expect it to fail. If it does, I'll notify the user that I can't proceed.I've followed all instructions to gather PR info, but everything's empty except the repository. The environment variables seem unset, preventing me from proceeding with the review. I'm stuck: I can't perform a review without data, but I'm also told not to ask for it. I'll try one last thing: gh pr list to see if I can find the
Error: Process completed with exit code 1.

…target` trigger and add instructions for non-comment triggers
@openshift-ci openshift-ci bot requested review from atheo89 and daniellutz August 18, 2025 08:02
@openshift-ci
Copy link

openshift-ci bot commented Aug 18, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign atheo89 for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📋 Review Summary

This PR updates the gemini-pr-review.yml workflow to correctly handle the pull_request_target trigger. The changes are straightforward and improve the robustness of the workflow.

🔍 General Feedback

  • The changes are well-implemented and follow best practices for GitHub Actions.
  • The addition of the pull_request_target trigger is a good improvement.
  • The explicit setting of additional_instructions for non-comment triggers is a good defensive programming practice.

Overall, this is a good PR that improves the CI/CD pipeline.

@github-actions
Copy link

There is a problem with the Gemini CLI PR review. Please check the action logs for details.

@jiridanek jiridanek merged commit c8f5aa5 into red-hat-data-services:main Aug 18, 2025
15 of 17 checks passed
@jiridanek jiridanek deleted the jd_gemini_prt branch August 18, 2025 08:07
Shafi-Hussain pushed a commit to odh-on-pz/notebooks-downstream that referenced this pull request Aug 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant