[SYCL] Implement Buffer copies in Graphs #192
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bensuo
added
the
Graph Implementation
EwanC
approved these changes
May 29, 2023
- Rework arg checking for nodes to use requirements instead - Added equality ops to some classes for req checking - New PI function for cmd buffer mem copies - New Memory::Manager method for buffer copies - Update ExecCGCommand to handle buffer copies - Two new e2e tests for buffer copies
- Only check SYCLMemObj - Remove previously added equality operators for accessor impl and prop list
|
We should also update the README table entry on handler copies to remove the wording about accessors not being supported yet. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note copies between accessors and host pointers are not supported at this time, but can be implemented later.