[SYCL] Refactor node class #177
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Bensuo
commented
May 15, 2023
Bensuo
commented
- Node class now wraps a commad group object
- Some changes to handler::finalize to support this
- Remove refactored handler CG creation
- Minor changes to CG classes to support copying
- Simplify enqueueImpCommandBufferKernel parameters
- Node class now wraps a commad group object - Some changes to handler::finalize to support this - Remove refactored handler CG creation - Minor changes to CG classes to support copying - Simplify enqueueImpCommandBufferKernel parameters
Bensuo
added
the
Graph Implementation
EwanC
reviewed
May 15, 2023
- Will prevent potential confusion when implementing.
EwanC
approved these changes
May 16, 2023
reble
reviewed
May 18, 2023
reble
reviewed
May 18, 2023
reble
reviewed
May 18, 2023
EwanC
pushed a commit
that referenced
this pull request
Jun 7, 2023
PR #177 updated the public handler class to add new members, without updating the `layout_handler.cpp` ABI test. This patch updates that test to reflect this change.
reble
pushed a commit
that referenced
this pull request
Jun 8, 2023
PR #177 updated the public handler class to add new members, without updating the `layout_handler.cpp` ABI test. This patch updates that test to reflect this change.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.