-
Notifications
You must be signed in to change notification settings - Fork 3
[SYCL][Graph] Query for backend command-buffer support #161
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
0250cb8 to
db35c27
Compare
julianmi
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me in general. One drawback I see is that this would prevent the explicit use of the emulation mode on L0, right? This might be useful for testing or comparing both approaches.
Bensuo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Yup, I think an L0 emulation mode still does have some value. I guess we'd want to agree on whether the L0 emulation mode should be exposed to users, or it's just for us developing the code. If emulation mode on L0 is just for our own comparison & testing, then I can add an in source |
reble
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
a752193 to
942e98d
Compare
I went with the second approach and added a |
Rather than the user deciding whether to use the emulation mode or backend command-buffer mode, it is less error prone to do it programmatically as a user can't select an unsupported config. This also fixes #90 where currently the `SYCL_EXT_ONEAPI_GRAPH` macro isn't defined when in emulation mode. Done by using a PI device info query in finalization. This also corresponds to a new UR device info query until the extension mechanism is decided oneapi-src/unified-runtime#458 but will be superceeded by whatever extension reporting mechanism is decided on. The only PI backend which reports support for command-buffer implementation is Level Zero, the other backends/adapters report no support. The vendor test macro test-e2e test is re-enabled with this change.
942e98d to
f8b30ab
Compare
Remove flag from getting sarted guide as well These were accidentally omitted from #161
Remove flag from getting sarted guide as well These were accidentally omitted from #161
Rather than the user deciding whether to use the emulation mode or backend command-buffer mode, it is less error-prone to do it programmatically as a user can't select an unsupported config.
This also fixes #90 where currently the
SYCL_EXT_ONEAPI_GRAPHmacro isn't defined when in emulation mode.Done by using a PI device info query in finalization. This also corresponds to a new UR device info query until the extension mechanism is decided oneapi-src/unified-runtime#458 but will be superceeded by whatever extension reporting mechanism is decided on.
The only PI backend which reports support for command-buffer implementation is Level Zero, the other backends/adapters report no support.