API v3: optimize project listing #12355
Open
+50
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is reviving an old optimization that was added in 363dccb but it was added for the old footer API, but it works for API v3 as well.
stsewd
commented
Jul 23, 2025
Comment on lines
-181
to
-182
| "related_projects", | ||
| "domains", |
There was a problem hiding this comment.
These were adding extra queries and not being used, as django ignores prefetching if anything other than objects.all() is called.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is reviving an old optimization that was
added in 363dccb
but it was added for the old footer API, but it works for API v3 as well.
This used to be 24 queries, now it went down to 16.