Only emit error event for fatal errors
#92
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
errorevent is currently allowed to be emitted for non-fatal errors, but our implementations actually only ever emit this as a fatal error and then close the stream.This simple PR ensures that the
errorevent is documented to only be allowed for fatal errors that will result in the stream being closed. Marking this as a new feature because one can now rely on this event and build reliable error handling logic.This means that this will not affect normal usage. However, it is a BC break for those that currently implement our interfaces and currently emit non-fatal errors. Empirical evidence suggests that this is not common at all (no single use of this is known).
Builds on top of #73
Resolves / closes #79