Skip to content

Conversation

@clue
Copy link
Member

@clue clue commented Jul 5, 2015

Closes #14

@clue
Copy link
Member Author

clue commented Jul 5, 2015

Note that this also describes the cancellation feature from PR #13, so we have to wait for that PR to land first.

@clue clue mentioned this pull request Jul 5, 2015
README.md Outdated
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For React/Promise >= 2.2 this can be:

Timer\timeout($promise, 10.0, $loop)
    ->then(function ($value) {
        // the operation finished within 10.0 seconds
    })
    ->otherwise(function (Timer\TimeoutException $error) {
        // the operation has failed due to a timeout
    })
    ->otherwise(function ($error) {
        // the input operation has failed due to some other error
    })
;

Note that i intentionally omitted rethrowing the exception.

@clue
Copy link
Member Author

clue commented Jul 5, 2015

Note that this also describes the cancellation feature from PR #13, so we have to wait for that PR to land first.

I've just removed this and force-pushed an update without the cancellation feature.

I'm aiming to get this in soon, while the cancellation feature may still take some time.

@clue
Copy link
Member Author

clue commented Jul 5, 2015

Ping @jsor

@jsor
Copy link
Member

jsor commented Jul 5, 2015

LGTM :shipit:

clue added a commit that referenced this pull request Jul 5, 2015
@clue clue merged commit 0f5a7fd into master Jul 5, 2015
@clue clue deleted the readme branch July 5, 2015 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants