Reject first() when stream emits an error event #7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WyriHaximus
added a commit
to WyriHaximus/http
that referenced
this pull request
Nov 28, 2017
reactphp/promise-stream#7 will be merged and tagged
jsor
approved these changes
Nov 28, 2017
WyriHaximus
added a commit
to WyriHaximus/http
that referenced
this pull request
Nov 29, 2017
reactphp/promise-stream#7 will be merged and tagged
WyriHaximus
added a commit
to WyriHaximus/http
that referenced
this pull request
Dec 3, 2017
reactphp/promise-stream#7 will be merged and tagged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
buffer()andall()functions already explicitly reject when the underlying stream emits an error event. The error event will always be followed by an immediate close event.This simple PR updates the
first()function to also explicitly reject when the underlying stream emits an error event. This allows consumers to get access to the underlyingException, which the following close event does not report.