Request parser interface

src/RequestParser.php

@@ -9,7 +9,7 @@
  * @event headers
  * @event error
  */
-class RequestParser extends EventEmitter
+class RequestParser extends EventEmitter implements RequestParserInterface
 {
     private $buffer = '';
     private $maxSize = 4096;

src/RequestParserFactory.php

@@ -0,0 +1,12 @@
+<?php namespace React\Http;
+
+class RequestParserFactory implements RequestParserFactoryInterface
+{
+    /**
+     * @return RequestParser
+     */
+    public function create()
+    {
+        return new RequestParser();
+    }
+}

src/RequestParserFactoryInterface.php

@@ -0,0 +1,9 @@
+<?php namespace React\Http;
+
+interface RequestParserFactoryInterface
+{
+    /**
+     * @return RequestParserInterface
+     */
+    public function create();
+}

src/RequestParserInterface.php

@@ -0,0 +1,19 @@
+<?php
+
+namespace React\Http;
+
+use Evenement\EventEmitterInterface;
+
+/**
+ * @event headers
+ * @event error
+ */
+interface RequestParserInterface extends EventEmitterInterface {
+
+    /**
+     * @param $data
+     * @return null
+     */
+    public function feed($data);
+
+}

src/Server.php

@@ -11,15 +11,16 @@ class Server extends EventEmitter implements ServerInterface
 {
     private $io;
 
-    public function __construct(SocketServerInterface $io)
+    public function __construct(SocketServerInterface $io, RequestParserFactoryInterface $parserFactory = null)
     {
         $this->io = $io;
 
-        $this->io->on('connection', function (ConnectionInterface $conn) {
+        $this->io->on('connection', function (ConnectionInterface $conn) use ($parserFactory) {
             // TODO: http 1.1 keep-alive
             // TODO: chunked transfer encoding (also for outgoing data)
 
-            $parser = new RequestParser();
+            $parserFactory = $parserFactory ?: new RequestParserFactory();
+            $parser = $parserFactory->create();
             $parser->on('headers', function (Request $request, $bodyBuffer) use ($conn, $parser) {
                 // attach remote ip to the request as metadata
                 $request->remoteAddress = $conn->getRemoteAddress();

tests/ServerTest.php

@@ -66,6 +66,24 @@ public function testResponseContainsPoweredByHeader()
         $this->assertContains("\r\nX-Powered-By: React/alpha\r\n", $conn->getData());
     }
 
+    public function testServerUsesProvidedRequestParserFactory()
+    {
+        $io = new ServerStub();
+
+        /** @var \React\Http\RequestParser|\PHPUnit_Framework_MockObject_MockObject $parser */
+        $parser = $this->getMockBuilder('React\Http\RequestParser')->getMock();
+        $parser->expects($this->once())->method('on');
+
+        /** @var \React\Http\RequestParserFactory | \PHPUnit_Framework_MockObject_MockObject $parserFactory */
+        $parserFactory = $this->getMockBuilder('React\Http\RequestParserFactory')->getMock();
+        $parserFactory->expects($this->once())->method('create')->willReturn($parser);
+
+        new Server($io, $parserFactory);
+
+        $conn = new ConnectionStub();
+        $io->emit('connection', array($conn));
+    }
+
     private function createGetRequest()
     {
         $data = "GET / HTTP/1.1\r\n";