Some code improvements #301
Conversation
| private $endPaused = false; | ||
| private $closePaused = false; | ||
| private $errorPaused = null; | ||
| private $errorPaused; |
There was a problem hiding this comment.
I understand that these assignments are essentially a NOOP. I've intentionally added these in the past to explicitly state that this property isn't initialized as part of the constructor (see also other occurrences). Would love to hear some more thoughts on this, but won't block this either way. 👍
There was a problem hiding this comment.
As for me, I think that the constructor itself says more explicitly about it, rather then assigned null default value. The idea behind these assignments wasn't clear for me, so I've considered them as useless. But if it is a common practice in the code, of course I will undo this change.
|
For the reference: This is also somewhat related to #295, does it make sense to cherry-pick (some of) the changes into a single PR? |
|
Sorry, but I'm not sure, that I know how to cherry pick commit from my request to someone's else 😞 |
|
I've just cherry picked @PabloJoan's relevant changes from #295 to this PR |
5 participants
This PR provides some small code improvements. It: