EIO supports PHP 7 these days, but breaks on nightly #28
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clue
requested changes
May 28, 2018
| if [[ "$TRAVIS_PHP_VERSION" != "hhvm" ]]; then | ||
| # install 'eio' PHP extension (does not support php 7) | ||
| if [[ "$TRAVIS_PHP_VERSION" != "7.0" ]]; then | ||
| if [[ "$TRAVIS_PHP_VERSION" != "nightly" ]]; then |
Member
There was a problem hiding this comment.
Comment above needs to be updated 👍
Member
Author
|
Ping @jsor (will squash and merge after you reviewed and approved this PR) |
jsor
approved these changes
Jun 14, 2018
WyriHaximus
added a commit
to WyriHaximus-labs/filesystem
that referenced
this pull request
Feb 14, 2021
WyriHaximus
added a commit
to WyriHaximus-labs/filesystem
that referenced
this pull request
Oct 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.