Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion composer.json
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
},
"require-dev": {
"clue/block-react": "^1.2",
"phpunit/phpunit": "^5.0 || ^4.8.10"
"phpunit/phpunit": "^6.4 || ^5.7 || ^4.8.35"
},
"autoload": {
"psr-4": { "React\\Dns\\": "src" }
Expand Down
3 changes: 2 additions & 1 deletion tests/Config/FilesystemFactoryTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,10 @@

namespace React\Test\Dns\Config;

use PHPUnit\Framework\TestCase;
use React\Dns\Config\FilesystemFactory;

class FilesystemFactoryTest extends \PHPUnit_Framework_TestCase
class FilesystemFactoryTest extends TestCase
{
/** @test */
public function parseEtcResolvConfShouldParseCorrectly()
Expand Down
3 changes: 2 additions & 1 deletion tests/Model/MessageTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -2,10 +2,11 @@

namespace React\Tests\Dns\Model;

use PHPUnit\Framework\TestCase;
use React\Dns\Query\Query;
use React\Dns\Model\Message;

class MessageTest extends \PHPUnit_Framework_TestCase
class MessageTest extends TestCase
{
public function testCreateRequestDesiresRecusion()
{
Expand Down
3 changes: 2 additions & 1 deletion tests/Protocol/BinaryDumperTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -2,10 +2,11 @@

namespace React\Tests\Dns\Protocol;

use PHPUnit\Framework\TestCase;
use React\Dns\Protocol\BinaryDumper;
use React\Dns\Model\Message;

class BinaryDumperTest extends \PHPUnit_Framework_TestCase
class BinaryDumperTest extends TestCase
{
public function testRequestToBinary()
{
Expand Down
3 changes: 2 additions & 1 deletion tests/Protocol/ParserTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -2,10 +2,11 @@

namespace React\Tests\Dns\Protocol;

use PHPUnit\Framework\TestCase;
use React\Dns\Protocol\Parser;
use React\Dns\Model\Message;

class ParserTest extends \PHPUnit_Framework_TestCase
class ParserTest extends TestCase
{
public function setUp()
{
Expand Down
3 changes: 2 additions & 1 deletion tests/Query/RecordBagTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -2,11 +2,12 @@

namespace React\Tests\Dns\Query;

use PHPUnit\Framework\TestCase;
use React\Dns\Query\RecordBag;
use React\Dns\Model\Message;
use React\Dns\Model\Record;

class RecordBagTest extends \PHPUnit_Framework_TestCase
class RecordBagTest extends TestCase
{
/**
* @covers React\Dns\Query\RecordBag
Expand Down
3 changes: 2 additions & 1 deletion tests/Query/RecordCacheTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -2,14 +2,15 @@

namespace React\Tests\Dns\Query;

use PHPUnit\Framework\TestCase;
use React\Cache\ArrayCache;
use React\Dns\Model\Message;
use React\Dns\Model\Record;
use React\Dns\Query\RecordCache;
use React\Dns\Query\Query;
use React\Promise\PromiseInterface;

class RecordCacheTest extends \PHPUnit_Framework_TestCase
class RecordCacheTest extends TestCase
{
/**
* @covers React\Dns\Query\RecordCache
Expand Down
3 changes: 2 additions & 1 deletion tests/Resolver/ResolveAliasesTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -2,12 +2,13 @@

namespace React\Tests\Dns\Resolver;

use PHPUnit\Framework\TestCase;
use React\Dns\Resolver\Resolver;
use React\Dns\Query\Query;
use React\Dns\Model\Message;
use React\Dns\Model\Record;

class ResolveAliasesTest extends \PHPUnit_Framework_TestCase
class ResolveAliasesTest extends TestCase
{
/**
* @covers React\Dns\Resolver\Resolver::resolveAliases
Expand Down
21 changes: 20 additions & 1 deletion tests/TestCase.php
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,9 @@

namespace React\Tests\Dns;

abstract class TestCase extends \PHPUnit_Framework_TestCase
use PHPUnit\Framework\TestCase as BaseTestCase;

abstract class TestCase extends BaseTestCase
{
protected function expectCallableOnce()
{
Expand Down Expand Up @@ -39,4 +41,21 @@ protected function createCallableMock()
{
return $this->getMockBuilder('React\Tests\Dns\CallableStub')->getMock();
}

public function setExpectedException($exception, $exceptionMessage = '', $exceptionCode = null)
{
if (method_exists($this, 'expectException')) {
// PHPUnit 5
$this->expectException($exception);
if ($exceptionMessage !== '') {
$this->expectExceptionMessage($exceptionMessage);
}
if ($exceptionCode !== null) {
$this->expectExceptionCode($exceptionCode);
}
} else {
// legacy PHPUnit 4
parent::setExpectedException($exception, $exceptionMessage, $exceptionCode);
}
}
}