Tests fail with PHP 7.1

[siwinski]

Tested with PHP 7.1.0 and 7.1.3

There were 3 errors:

1) React\Tests\Dns\Query\ExecutorTest::resolveShouldRetryWithTcpIfResponseIsTruncated
ArgumentCountError: Too few arguments to function React\Tests\Dns\Query\ExecutorTest::React\Tests\Dns\Query\{closure}(), 1 passed in /tmp/dns/vendor/phpunit/phpunit-mock-objects/src/Framework/MockObject/Stub/ReturnCallback.php on line 25 and exactly 2 expected

/tmp/dns/tests/Query/ExecutorTest.php:352
/tmp/dns/src/Query/Executor.php:113
/tmp/dns/tests/Query/ExecutorTest.php:410
/tmp/dns/src/Query/Executor.php:133
/tmp/dns/src/Query/Executor.php:73
/tmp/dns/src/Query/Executor.php:125
/tmp/dns/tests/Query/ExecutorTest.php:410
/tmp/dns/src/Query/Executor.php:133
/tmp/dns/src/Query/Executor.php:46
/tmp/dns/tests/Query/ExecutorTest.php:163

2) React\Tests\Dns\Query\ExecutorTest::resolveShouldRetryWithTcpIfUdpThrows
ArgumentCountError: Too few arguments to function React\Tests\Dns\Query\ExecutorTest::React\Tests\Dns\Query\{closure}(), 1 passed in /tmp/dns/vendor/phpunit/phpunit-mock-objects/src/Framework/MockObject/Stub/ReturnCallback.php on line 25 and exactly 2 expected

/tmp/dns/tests/Query/ExecutorTest.php:352
/tmp/dns/src/Query/Executor.php:113
/tmp/dns/tests/Query/ExecutorTest.php:410
/tmp/dns/src/Query/Executor.php:133
/tmp/dns/src/Query/Executor.php:46
/tmp/dns/tests/Query/ExecutorTest.php:194

3) React\Tests\Dns\Query\ExecutorTest::resolveShouldCancelTimerWhenFullResponseIsReceived
ArgumentCountError: Too few arguments to function React\Tests\Dns\Query\ExecutorTest::React\Tests\Dns\Query\{closure}(), 1 passed in /tmp/dns/vendor/phpunit/phpunit-mock-objects/src/Framework/MockObject/Stub/ReturnCallback.php on line 25 and exactly 2 expected

/tmp/dns/tests/Query/ExecutorTest.php:352
/tmp/dns/src/Query/Executor.php:113
/tmp/dns/tests/Query/ExecutorTest.php:410
/tmp/dns/src/Query/Executor.php:133
/tmp/dns/src/Query/Executor.php:46
/tmp/dns/tests/Query/ExecutorTest.php:304

[WyriHaximus]

Thank you for reporting, this shouldn't happen. Could you file a PR to test against PHP 7.1 and fixes the arisen issue?

[siwinski]

FYI: These PHP 7.1 failures were introduced in v0.4.5

[siwinski]

@WyriHaximus sure