Skip to content

DNS resolver is optional #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ojhaujjwal wants to merge 1 commit into from
Closed

DNS resolver is optional #7

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 16 additions & 2 deletions src/Connector.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,12 +13,26 @@ class Connector implements ConnectorInterface
private $loop;
private $resolver;

public function __construct(LoopInterface $loop, Resolver $resolver)
public function __construct(LoopInterface $loop, Resolver $resolver = null)
{
$this->loop = $loop;
$this->resolver = $resolver;
}

public function setDnsResolver(Resolver $resolver)
{
$this->resolver = $resolver;
}

public function getDnsResolver()
{
if (!$this->resolver instanceof Resolver) {
throw new \RuntimeException('DNS Resolver is not set.');
}

return $this->resolver;
}

public function create($host, $port)
{
return $this
Expand Down Expand Up @@ -97,6 +111,6 @@ protected function resolveHostname($host)
return Promise\resolve($host);
}

return $this->resolver->resolve($host);
return $this->getDnsResolver()->resolve($host);
}
}