Sync with reactjs.org @ 022c1b2f #169
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removed renderExamplePlaceholder as its never used
Fix shallow renderer link on test utils page
It solves a broken link on HOC doc
Project dependency doesn't add itself it global PATH. So call `tsc` will work either with globally installed typescript, or from npm/yarn script.
"collocation" instead of "colocation".
Fix typo in Hooks FAQ
Fix command for initializing tsconfig
Fix typo in blog
another-guy
reviewed
Feb 20, 2019
| @@ -139,7 +139,7 @@ Pass a mocked component module to this method to augment it with useful methods | |||
|
|
|||
| > Note: | |||
| > | |||
| > `mockComponent()` is a legacy API. We recommend using [shallow rendering](/docs/test-utils.html#shallow-rendering) or [`jest.mock()`](https://facebook.github.io/jest/docs/en/tutorial-react-native.html#mock-native-modules-using-jestmock) instead. | |||
| > `mockComponent()` is a legacy API. We recommend using [shallow rendering](/docs/shallow-renderer.html) or [`jest.mock()`](https://facebook.github.io/jest/docs/en/tutorial-react-native.html#mock-native-modules-using-jestmock) instead. | |||
There was a problem hiding this comment.
Should be fixed in #97
another-guy
reviewed
Feb 20, 2019
| @@ -14,7 +14,7 @@ const EnhancedComponent = higherOrderComponent(WrappedComponent); | |||
|
|
|||
| Whereas a component transforms props into UI, a higher-order component transforms a component into another component. | |||
|
|
|||
| HOCs are common in third-party React libraries, such as Redux's [`connect`](https://github.com/reactjs/react-redux/blob/master/docs/api/connect.md#connectmapstatetoprops-mapdispatchtoprops-mergeprops-options) and Relay's [`createFragmentContainer`](http://facebook.github.io/relay/docs/en/fragment-container.html). | |||
| HOCs are common in third-party React libraries, such as Redux's [`connect`](https://github.com/reduxjs/react-redux/blob/master/docs/api/connect.md#connect) and Relay's [`createFragmentContainer`](http://facebook.github.io/relay/docs/en/fragment-container.html). | |||
There was a problem hiding this comment.
Should be fixed in #167
another-guy
reviewed
Feb 20, 2019
| @@ -216,10 +216,18 @@ Congrats! You've installed the latest version of TypeScript into your project. I | |||
| ``` | |||
|
|
|||
| ### Configuring the TypeScript Compiler {#configuring-the-typescript-compiler} | |||
| The compiler is of no help to us until we tell it what to do. In TypeScript, these rules are defined in a special file called `tsconfig.json`. To generate this file run: | |||
| The compiler is of no help to us until we tell it what to do. In TypeScript, these rules are defined in a special file called `tsconfig.json`. To generate this file: | |||
There was a problem hiding this comment.
Should be fixed in #166
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR was automatically generated.
Merge changes from reactjs.org at 022c1b2
The following files have conflicts and may need new translations:
Please fix the conflicts by pushing new commits to this pull request, either by editing the files directly on GitHub or by checking out this branch.
DO NOT SQUASH MERGE THIS PULL REQUEST!
Doing so will "erase" the commits from master and cause them to show up as conflicts the next time we merge.