Clarify callback parameters #626
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Clarifies the callback parameters for React.Children.map() and React.Children.forEach() by noting that they can also contain an optional `index` parameter as a second argument.
|
Deploy preview for reactjs failed. Built with commit 3a94eb0 https://app.netlify.com/sites/reactjs/deploys/5a891d70fd0efa595665e259 |
yangshun
reviewed
Mar 24, 2018
|
|
||
| ```javascript | ||
| React.Children.map(children, function[(thisArg)]) | ||
| React.Children.map(children, function(thisArg, [index])) |
There was a problem hiding this comment.
The comma for optional parameters should be within the square bracket -
React.Children.map(children, function(thisArg [,index]))
BetterZxx
pushed a commit
to BetterZxx/react.dev
that referenced
this pull request
Mar 21, 2023
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clarifies the callback parameters for React.Children.map() and React.Children.forEach() by noting that they can also contain an optional
indexparameter as a second argument.I'm not sure if the way I formatted the parameters in the function is correct. I noticed that before,
thisArgwas wrapped in brackets. Was that to signify it was optional? Feel free to correct me on that.Preview of the change:
