Skip to content

Conversation

@thisisaneeq
Copy link
Contributor

The second command won't work until the "flow" is added to scripts.

The second command won't work until the "flow" is added to scripts.
@facebook-github-bot
Copy link
Collaborator

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

@gaearon
Copy link
Member

gaearon commented Feb 10, 2018

Are you sure? I think yarn will attempt to delegate to the Flow binary if the script with the same name is missing. Which is what we need.

@reactjs-bot
Copy link

reactjs-bot commented Feb 10, 2018

Deploy preview for reactjs ready!

Built with commit 9339b98

https://deploy-preview-608--reactjs.netlify.com

@facebook-github-bot
Copy link
Collaborator

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@thisisaneeq
Copy link
Contributor Author

@gaearon Well, you are right. yarn does that, but npm doesn't.

@gaearon gaearon merged commit 53f4ce7 into reactjs:master Feb 12, 2018
@gaearon
Copy link
Member

gaearon commented Feb 12, 2018

Thanks for explaining.

@thisisaneeq thisisaneeq deleted the patch-1 branch March 30, 2018 01:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants