Skip to content

Fix CRA code splitting link #1765

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 3, 2019
Merged

Fix CRA code splitting link #1765

merged 1 commit into from
Mar 3, 2019

Conversation

raed667
Copy link
Contributor

@raed667 raed667 commented Feb 28, 2019

This commit should help redirect people to the proper "code splitting" create app page instead of the old github link.

@facebook-github-bot
Copy link
Collaborator

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

@reactjs-bot
Copy link

Deploy preview for reactjs ready!

Built with commit 5305b8f

https://deploy-preview-1765--reactjs.netlify.com

@facebook-github-bot
Copy link
Collaborator

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@sophiebits sophiebits merged commit 8803c63 into reactjs:master Mar 3, 2019
@sophiebits
Copy link
Member

Thanks!

@raed667 raed667 deleted the patch-1 branch March 4, 2019 08:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants