Migrate repo URLs #13
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yangshun
commented
Oct 6, 2017
| @@ -66,7 +66,7 @@ The [fbjs repository](https://github.com/facebook/fbjs) exists because React sha | |||
| After cloning the [React repository](https://github.com/facebook/react), you will see a few top-level folders in it: | |||
|
|
|||
| * [`src`](https://github.com/facebook/react/tree/master/src) is the source code of React. **If your change is related to the code, `src` is where you'll spend most of your time.** | |||
| * [`docs`](https://github.com/facebook/react/tree/master/docs) is the React documentation website. When you change APIs, make sure to update the relevant Markdown files. | |||
| * [`docs`](https://github.com/reactjs/reactjs.org/tree/master/content) is the React documentation website. When you change APIs, make sure to update the relevant Markdown files. | |||
There was a problem hiding this comment.
Strictly speaking this line should be removed because the docs is no longer in the facebook/react repo.
There was a problem hiding this comment.
I think it's actually pretty important to keep this link here. 😄
There was a problem hiding this comment.
We should make a pass after repo re-organization and rewrite this.
There was a problem hiding this comment.
Sorry I meant that it should be removed from this section and rephrased to suit the new repo structure. Definitely agree we should keep the link in this page!
|
Deploy preview ready! Built with commit fb02750 |
bvaughn
approved these changes
Oct 6, 2017
| @@ -66,7 +66,7 @@ The [fbjs repository](https://github.com/facebook/fbjs) exists because React sha | |||
| After cloning the [React repository](https://github.com/facebook/react), you will see a few top-level folders in it: | |||
|
|
|||
| * [`src`](https://github.com/facebook/react/tree/master/src) is the source code of React. **If your change is related to the code, `src` is where you'll spend most of your time.** | |||
| * [`docs`](https://github.com/facebook/react/tree/master/docs) is the React documentation website. When you change APIs, make sure to update the relevant Markdown files. | |||
| * [`docs`](https://github.com/reactjs/reactjs.org/tree/master/content) is the React documentation website. When you change APIs, make sure to update the relevant Markdown files. | |||
There was a problem hiding this comment.
I think it's actually pretty important to keep this link here. 😄
gaearon
added a commit
to gaearon/reactjs.org
that referenced
this pull request
Feb 9, 2019
jhonmike
pushed a commit
to jhonmike/reactjs.org
that referenced
this pull request
Jul 1, 2020
* Translate Fragments * Fix PR review
BetterZxx
pushed a commit
to BetterZxx/react.dev
that referenced
this pull request
Mar 21, 2023
* docs(cn): add `Composition vs Inheritance` translations * docs(cn): add missing �colon * Update composition-vs-inheritance.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migrate some old repo URLs to the new repo URLs.