fix: prevent gatsby file detection from breaking path field #1226
Conversation
Fixes reactjs#1088 This should fix the path issues that people intermittently run into. Gatsby sees the relative path (and the parent node with an absolute path), joins on the parent path and the relative path, and presumes it's a file... which is normally good, but which here is not what we want beacuse then we're getting a resolver of type file instead of type string referring to the relative path of the document. This seems to fix a (long standing?) bug where the "Edit this Page" button is broken, as well. e.g. see [this page](https://reactjs.org/community/support.html) which _should_ have an Edit this Page button I'd need to think more as to whether there's a cleaner fix here, but this seems to work pretty well!
|
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed. If you have received this in error or have any questions, please contact us at [email protected]. Thanks! |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
|
Deploy preview for reactjs ready! Built with commit 77a39ff |
|
Awesome work! 🥇 |
|
Thank you!! |
Fixes #1088
This should fix the path issues that people intermittently run into.
Gatsby sees the relative path (and the parent node with an absolute
path), joins on the parent path and the relative path, and presumes it's
a file... which is normally good, but which here is not what we want
as we're then getting a resolver of type file instead of type
string referring to the relative path of the document.
This seems to fix a (long standing?) bug where the "Edit this Page"
button is broken, as well. e.g. see a current community page vs. deploy preview community page
I'd need to think more as to whether there's a cleaner fix here, but
this seems to work pretty well!