Skip to content

Add PostCSS mention #1220

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Oct 4, 2018
Merged

Add PostCSS mention #1220

merged 4 commits into from
Oct 4, 2018

Conversation

Timer
Copy link
Contributor

@Timer Timer commented Oct 2, 2018

Mentions that users can now use new CSS features in older browsers.

@reactjs-bot
Copy link

reactjs-bot commented Oct 2, 2018

Deploy preview for reactjs ready!

Built with commit ac27577

https://deploy-preview-1220--reactjs.netlify.com

@@ -28,7 +28,8 @@ Here's a short summary of what's new in this release:
* 🐈 You can try the experimental [Yarn Plug'n'Play mode](https://github.com/yarnpkg/rfcs/pull/101) that removes `node_modules`.
* 🕸 You can now [plug your own proxy implementation](https://github.com/facebook/create-react-app/blob/master/packages/react-scripts/template/README.md#configuring-the-proxy-manually) in development to match your backend API.
* 🚀 You can now use [packages written for latest Node versions](https://github.com/sindresorhus/ama/issues/446#issuecomment-281014491) without breaking the build.
* 💄 You can now optionally get a smaller CSS bundle if you only plan to target modern browsers.
* 💄 We added [PostCSS](https://github.com/csstools/postcss-preset-env#postcss-preset-env-) so you can use [new CSS features](https://cssdb.org/) in old browsers.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's move up to other "We ..."?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@@ -28,7 +28,8 @@ Here's a short summary of what's new in this release:
* 🐈 You can try the experimental [Yarn Plug'n'Play mode](https://github.com/yarnpkg/rfcs/pull/101) that removes `node_modules`.
* 🕸 You can now [plug your own proxy implementation](https://github.com/facebook/create-react-app/blob/master/packages/react-scripts/template/README.md#configuring-the-proxy-manually) in development to match your backend API.
* 🚀 You can now use [packages written for latest Node versions](https://github.com/sindresorhus/ama/issues/446#issuecomment-281014491) without breaking the build.
* 💄 You can now optionally get a smaller CSS bundle if you only plan to target modern browsers.
* 💄 We added [PostCSS](https://github.com/csstools/postcss-preset-env#postcss-preset-env-) so you can use [new CSS features](https://cssdb.org/) in old browsers.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think ideally we should send a PR to https://preset-env.cssdb.org/features#all-property to allow linking to "stage 3" preset (currently it's just a select). Then we could link to that. Otherwise it's too ambiguous about which features we enable.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I specified stage 3+ for now.

@Timer
Copy link
Contributor Author

Timer commented Oct 2, 2018

@jonathantneal can we please get a link to a page containing only stage 3 css features? Or a way to filter down by defailt?

@jonathantneal
Copy link

@Timer, will this work? https://preset-env.cssdb.org/features#stage-3

@Timer
Copy link
Contributor Author

Timer commented Oct 2, 2018

Yes, perfect!

@gaearon gaearon merged commit 3ba06e0 into reactjs:master Oct 4, 2018
@gaearon
Copy link
Member

gaearon commented Oct 4, 2018

Thanks all ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants