Improves the documentation on Reconciliation #108
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview ready! Built with commit 348a727 |
|
Thanks, that makes me much more confident about using React (or React-like libraries) regarding third-party components integration :) |
|
I'm not a big fan of adding things in parens that disrupt the flow of the paragraph. These always looked like they're tacked on by somebody else 😛 Try to read it aloud—by the time I get to the last sentence I get a bit lost. Can you maybe send a follow up PR that restructures this paragraph to look like it was written organically by a single person? Maybe by splitting it into two paragraphs or shuffling the sentences around. Thanks! |
|
Sure, you're right. I'll follow up with a new PR. |
rosenfeld
added a commit
to rosenfeld/reactjs.org
that referenced
this pull request
Oct 10, 2017
I've improved my previous changes to what re-render means by following Dan Abramov's suggestion on the writing style to remove the parenthesis from that paragraph. See issue reactjs#108 for more context.
|
done |
gaearon
pushed a commit
that referenced
this pull request
Oct 10, 2017
I've improved my previous changes to what re-render means by following Dan Abramov's suggestion on the writing style to remove the parenthesis from that paragraph. See issue #108 for more context.
jhonmike
pushed a commit
to jhonmike/reactjs.org
that referenced
this pull request
Jul 1, 2020
* Line: 269 * Translate: Using the State Hook * Update content/docs/hooks-state.md Co-Authored-By: vinicius98s <[email protected]> * Update content/docs/hooks-state.md Co-Authored-By: vinicius98s <[email protected]> * Update content/docs/hooks-state.md Co-Authored-By: vinicius98s <[email protected]> * Update hooks-state.md * Update hooks-state.md * Update content/docs/hooks-state.md Co-Authored-By: vinicius98s <[email protected]> * Update hooks-state.md * Update content/docs/hooks-state.md Co-Authored-By: vinicius98s <[email protected]> * Update content/docs/hooks-state.md Co-Authored-By: vinicius98s <[email protected]> * Update content/docs/hooks-state.md Co-Authored-By: vinicius98s <[email protected]> * Update content/docs/hooks-state.md Co-Authored-By: vinicius98s <[email protected]> * Update content/docs/hooks-state.md Co-Authored-By: vinicius98s <[email protected]> * Update content/docs/hooks-state.md Co-Authored-By: vinicius98s <[email protected]> * Update content/docs/hooks-state.md Co-Authored-By: vinicius98s <[email protected]>
BetterZxx
pushed a commit
to BetterZxx/react.dev
that referenced
this pull request
Mar 21, 2023
* 📝 docs Typechecking With PropTypes * fix: typechecking doc * fix: doc * fix: doc * fix: doc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the same pull request as facebook/react#9994 backported to this project as requested by @bvaughn. Thanks.