Skip to content

fix netlify (?) #1065

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jul 18, 2018
Merged

fix netlify (?) #1065

merged 5 commits into from
Jul 18, 2018

Conversation

alexkrolick
Copy link
Collaborator

@alexkrolick alexkrolick commented Jul 17, 2018

tweaking stuff for netlify to try to fix #1058

@reactjs-bot
Copy link

reactjs-bot commented Jul 17, 2018

Deploy preview for reactjs ready!

Built with commit 47e398a

https://deploy-preview-1065--reactjs.netlify.com

@@ -35,7 +35,9 @@ export const pageQuery = graphql`
prev
}
fields {
path
path {
id
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@KyleAMathews any idea why this now requires { ... }?

screen shot 2018-07-16 at 9 23 53 pm

@alexkrolick alexkrolick changed the title update install, cache settings fix netlify (?) Jul 17, 2018
@alexkrolick
Copy link
Collaborator Author

alexkrolick commented Jul 17, 2018

new errors at least:

9:45:41 PM: error Failed to process image /opt/build/repo/content/images/docs/thinking-in-react-tagtree.png
9:45:41 PM: 
9:45:41 PM:   Error: spawn /opt/build/repo/node_modules/pngquant-bin/vendor/pngquant ENOENT
9:45:41 PM:   
9:45:41 PM:   - child_process.js:190 Process.ChildProcess._handle.onexit
9:45:41 PM:     internal/child_process.js:190:19
9:45:41 PM:   
9:45:41 PM:   - child_process.js:372 onErrorNT
9:45:41 PM:     internal/child_process.js:372:16
9:45:41 PM:   
9:45:41 PM:   - next_tick.js:138 _combinedTickCallback
9:45:41 PM:     internal/process/next_tick.js:138:11
9:45:41 PM:   
9:45:41 PM:   - next_tick.js:180 process._tickCallback
9:45:41 PM:     internal/process/next_tick.js:180:9
9:45:41 PM:   
warning There are conflicting field types in your data. GraphQL schema will omit those fields.
MarkdownRemark.frontmatter.redirect_from:
 - type: array<string>
   value: [ 'docs/tutorial.html', ... ]
   source: File "content/tutorial/tutorial.md"
 - type: string
   value: 'docs/conferences.html'
   source: File "content/community/conferences.md"

works locally...
@alexkrolick
Copy link
Collaborator Author

(ノ°Д°)ノ︵ ┻━┻

IDK... you can debug the Netlify docker build locally apparently, might try that later https://github.com/netlify/build-image#testing-locally

@KyleAMathews
Copy link
Contributor

Looks like a bad node_modules cache where pngquant is missing

@alexkrolick
Copy link
Collaborator Author

Nuking the cache before every build seems reasonable given how many problems we've had with it

@alexkrolick alexkrolick merged commit 1863317 into reactjs:master Jul 18, 2018
@sophiebits
Copy link
Member

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deploys are failing
5 participants