Skip to content

Update conditional-rendering.md #1030

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Conversation

silvaw
Copy link

@silvaw silvaw commented Jul 2, 2018

Using WarningBanner with a capital W, causes IDE warns me that "Primitive value returned from constructor will be lost when called with 'new'".
IDE expect function names to start with a lowercase letter. Since WarningBanner function is called with a capital W, it thinks it's a class declaration.

Using WarningBanner with a capital W, causes IDE warns me that "Primitive value returned from constructor will be lost when called with 'new'".
IDE expect function names to start with a lowercase letter. Since WarningBanner function is called with a capital W, it thinks it's a class declaration.
@facebook-github-bot
Copy link
Collaborator

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

@reactjs-bot
Copy link

Deploy preview for reactjs failed.

Built with commit f7d27aa

https://app.netlify.com/sites/reactjs/deploys/5b3a91b567610c0d5409d0f0

@alexkrolick
Copy link
Collaborator

JSX element names must be capitalized:

https://github.com/reactjs/reactjs.org/blob/master/content/docs/jsx-in-depth.md#user-defined-components-must-be-capitalized

Sounds like your linter needs to be changed to reflect this

@alexkrolick alexkrolick closed this Jul 2, 2018
@silvaw silvaw deleted the patch-1 branch July 2, 2018 21:11
BetterZxx pushed a commit to BetterZxx/react.dev that referenced this pull request Mar 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants