-
Notifications
You must be signed in to change notification settings - Fork 7.7k
Defer babel loading #100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Defer babel loading #100
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
1d48f75
load babel only when needed
renanpvaz 80b1b83
linting fixes
renanpvaz 7efe10f
update constant name
renanpvaz b843de7
Merge branch 'master' of https://github.com/reactjs/reactjs.org into …
renanpvaz a02139b
undo changes to algolia search
renanpvaz 36e1185
render simple placeholder while Babel loads
renanpvaz 0a255fe
Merge branch 'master' of https://github.com/reactjs/reactjs.org into …
renanpvaz ba6a786
simplify placeholder
renanpvaz File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -19,7 +19,6 @@ if (process.env.NODE_ENV === `production`) { | |
|
||
const JS_NPM_URLS = [ | ||
'//unpkg.com/[email protected]/dist/cdn/docsearch.min.js', | ||
'//unpkg.com/[email protected]/babel.min.js', | ||
]; | ||
|
||
export default class HTML extends Component { | ||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -11,5 +11,6 @@ | |
// the SSR part in node.js we won't have a proper location. | ||
const urlRoot = 'https://reactjs.org'; | ||
const version = '16.0.0'; | ||
const babelURL = '//unpkg.com/[email protected]/babel.min.js'; | ||
|
||
export {urlRoot, version}; | ||
export {urlRoot, version, babelURL}; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,22 @@ | ||
/** | ||
* Copyright (c) 2013-present, Facebook, Inc. | ||
* | ||
* This source code is licensed under the MIT license found in the | ||
* LICENSE file in the root directory of this source tree. | ||
* | ||
* @emails react-core | ||
*/ | ||
|
||
'use strict'; | ||
|
||
export default url => | ||
new Promise((resolve, reject) => | ||
document.head.appendChild( | ||
Object.assign(document.createElement('script'), { | ||
async: true, | ||
src: url, | ||
onload: resolve, | ||
onerror: reject, | ||
}), | ||
), | ||
); |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What are your thoughts about showing a loading placeholder in the 4 divs in question until Babel has finished loading?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's a good idea, I can see that it is flashing once it loads. To fix this should I style the divs at content/index.md?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably not. (We actually need to clean up
index.md
, see #97)I would try maybe temporarily rendering a placeholder into the container from the Home template.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So you mean that I should use
ReactDOM.render
likemountCodeExample
does?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably 😄