-
Notifications
You must be signed in to change notification settings - Fork 753
Fix ReactDomClient bug #1278
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
justin808
merged 9 commits into
master
from
fix-bug-with-requiring-react-dom-with-sporockets
May 19, 2023
Merged
Fix ReactDomClient bug #1278
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
1fc6563
Fix the bug
ahangarha 33d9da7
Update react and ujs
ahangarha b6811a0
update CI, release, & ujs source
Judahmeek 3d2983b
update gemfiles
Judahmeek 98cd130
final touch up
Judahmeek bca16c7
Update check_for_uncommitted_files.sh
justin808 f6861c3
Update reactDomClient.js
justin808 172c1bb
replace yarn upgrade with yarn install
Judahmeek 11c498e
update for 2.7.1
Judahmeek File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -6,17 +6,34 @@ | |
# For more information see: https://github.com/marketplace/actions/setup-ruby-jruby-and-truffleruby | ||
|
||
name: Ruby | ||
on: [push, pull_request] | ||
|
||
on: [push] | ||
jobs: | ||
check_react_and_ujs: | ||
strategy: | ||
fail-fast: true | ||
matrix: | ||
ruby: [2.7] | ||
runs-on: ubuntu-latest | ||
steps: | ||
- uses: actions/checkout@v3 | ||
- uses: ruby/setup-ruby@v1 | ||
with: | ||
bundler: 2.4.9 | ||
ruby-version: ${{ matrix.ruby }} | ||
- uses: actions/setup-node@v3 | ||
- run: bundle install | ||
- run: yarn | ||
- run: bundle exec rake react:update | ||
- run: bundle exec rake ujs:update | ||
- run: ./check_for_uncommitted_files.sh | ||
|
||
test: | ||
needs: check_react_and_ujs | ||
strategy: | ||
fail-fast: false | ||
matrix: | ||
ruby: | ||
- 2.7.0 | ||
- 2.6.5 | ||
# TODO restore testing against JRuby w/ therubyrhino | ||
# - jruby-9.3.7.0 | ||
ruby: [2.7] | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Not related to this PR, but I think we should add ruby 3 to the matrix for our tests. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. followup PR |
||
gemfile: | ||
# These have webpacker: | ||
- rails_5.2_no_sprockets | ||
|
@@ -37,6 +54,7 @@ jobs: | |
- uses: actions/setup-node@v3 | ||
- uses: ruby/setup-ruby@v1 | ||
with: | ||
bundler: 2.4.9 | ||
ruby-version: ${{ matrix.ruby }} | ||
# TODO: Impalement caching | ||
# bundler-cache: true | ||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,14 @@ | ||
#!/bin/bash | ||
set -e | ||
|
||
status=$(git status --porcelain) | ||
if [ -n "$status" ]; then | ||
status="${status//'%'/'%25'}" | ||
status="${status//$'\n'/'%0A'}" | ||
status="${status//$'\r'/'%0D'}" | ||
echo "$status" | ||
exit 1 | ||
else | ||
echo "The repository is clean" | ||
exit 0 | ||
fi |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it is better to extract this logic into another rake task and use it in both:
Is will be DRY and also prevents adding bash script in the root of the project.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not convinced.