Skip to content

Thinking in react #15

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 16 commits into from
Feb 21, 2019
Merged

Conversation

marcinostrouch
Copy link
Contributor

No description provided.


Imagine that we already have a JSON API and a mock from our designer. The mock looks like this:
Załóżmy, że mamy już gotowy JSON API oraz projekt designu. Projekt wygląda następująco:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Załóżmy, że mamy już gotowy JSON API oraz projekt designu. Projekt wygląda następująco:
Załóżmy, że mamy już gotowe API JSON-owe oraz projekt graficzny. Projekt wygląda następująco:

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"projekt graficzny" - oczywiście, że tak.

Czy API w naszym tłumaczeniu ma być w rodzaju nijakim - "to" API?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Moim zdaniem zależy to głównie od wymowy: ten "ej-pi-aj" (jak: ten interfejs), ale to "api" (jak: to okapi).

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Załóżmy, że mamy już gotowy JSON API oraz projekt designu. Projekt wygląda następująco:
Załóżmy, że mamy już gotowy interfejs JSON API oraz projekt graficzny. Projekt wygląda następująco:

Copy link
Member

@jakubdrozdek jakubdrozdek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Jeszcze drobne poprawki... :-)

@netlify
Copy link

netlify bot commented Feb 21, 2019

Deploy preview for pl-reactjs ready!

Built with commit dff1ec0

https://deploy-preview-15--pl-reactjs.netlify.com

@jakubdrozdek jakubdrozdek merged commit 81e1b2e into reactjs:master Feb 21, 2019
@jakubdrozdek jakubdrozdek added 🌐 translated Translation is completed for this page and removed needs author response Changes requested needing author's input needs review A pull request ready to be reviewed 🚼 good first issue Good for newcomers labels Feb 28, 2019
@marcinostrouch marcinostrouch deleted the thinking-in-react branch March 20, 2019 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🌐 translated Translation is completed for this page
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants