Lifting state up translated to Polish #11
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iamarek
requested review from
TeoTN,
bartlomiejzuber,
cvqprs,
jakubdrozdek and
marcinostrouch
|
|
@jakubdrozdek to tak w zasadzie lifting przetłumaczyłem, co do inputa, to chodzi mi o input jako tag HTMLowy, zakładam, że tego nie tłumaczymy, bo byłoby dziwnie, ale wole się upewnić. |
|
Nie, znaczników nie tłumaczymy, tak jak nie tłumaczymy zmiennych i niektórych innych rzeczy w kodzie. |
jakubdrozdek
added
💪 long page - more than 400 lines
bartlomiejzuber
previously approved these changes
Feb 17, 2019
There was a problem hiding this comment.
Przejrzałem całość ale @jakubdrozdek zrobił dobrą robotę więc nic więcej nie znalazłem. Ze swojej strony daje approve. 👍
|
To teraz czekamy na poprawki od @iamarek i można mergować :-) |
jakubdrozdek
approved these changes
Feb 17, 2019
94 tasks
jakubdrozdek
added
🌐 translated
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Na pewno kilka kwestii do ustalenia 🙈