Translating Courses #211
Merged
Translating Courses #211
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
19 tasks
|
Deploy preview for es-reactjs ready! Built with commit 2e425a3 |
carburo
requested changes
Mar 22, 2019
There was a problem hiding this comment.
Hi @jpvg10! Thank you again for another contribution.
- Yes, we should leave courses names untranslated. Nevertheless, later on we should look for courses in Spanish that we can add. If something comes into your mind let us know on this thread.
- I notice you left the title in line number 2 untranslated.
- I think that “palabras complicadas” could work in that context.
- I also left a couple of comments about other things.
Let me know what you think.
|
LGTM! Merging! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #200
I didn't translate the course names. Let me know if it is needed.
Also I'm not sure about a couple translations:
buzzwords -> palabras complicadas
doers -> realizadores
Please review and let me know what you think