Skip to content

add Support page translation #207

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Mar 21, 2019
Merged

add Support page translation #207

merged 6 commits into from
Mar 21, 2019

Conversation

RamirezAlex
Copy link
Contributor

@RamirezAlex RamirezAlex mentioned this pull request Mar 20, 2019
19 tasks
@netlify
Copy link

netlify bot commented Mar 20, 2019

Deploy preview for es-reactjs ready!

Built with commit 8c6f880

https://deploy-preview-207--es-reactjs.netlify.com

Copy link
Member

@carburo carburo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you again @RamirezAlex. Nice to see you back!
I made just a few suggestions. Tell me what you think.

@RamirezAlex
Copy link
Contributor Author

Thanks @carburo, I applied the suggested changes. I am not sure about the accent in Dónde obtener asistencia because it is not a question or exclamation, but I added it, though.

@carburo
Copy link
Member

carburo commented Mar 21, 2019

Yes, you are right, I just thought it could work better as a question in Spanish, but then I should have added question marks. Let's leave it as it was, without the accent.
This seems great. Merging!

@carburo carburo merged commit 009e39f into reactjs:master Mar 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants