Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/Modal.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@ import useWaitForDOMRef, { DOMContainer } from './useWaitForDOMRef';
import { TransitionCallbacks } from './types';
import useWindow from './useWindow';
import { renderTransition, TransitionHandler } from './ImperativeTransition';
import { isEscKey } from './utils';

let manager: ModalManager;

Expand Down Expand Up @@ -391,7 +392,7 @@ const Modal: React.ForwardRefExoticComponent<
});

const handleDocumentKeyDown = useEventCallback((e: KeyboardEvent) => {
if (keyboard && e.keyCode === 27 && modal.isTopModal()) {
if (keyboard && isEscKey(e) && modal.isTopModal()) {
onEscapeKeyDown?.(e);

if (!e.defaultPrevented) {
Expand Down
4 changes: 2 additions & 2 deletions src/useRootClose.ts
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,8 @@ import useClickOutside, {
ClickOutsideOptions,
getRefTarget,
} from './useClickOutside';
import { isEscKey } from './utils';

const escapeKeyCode = 27;
const noop = () => {};

export interface RootCloseOptions extends ClickOutsideOptions {
Expand Down Expand Up @@ -37,7 +37,7 @@ function useRootClose(
useClickOutside(ref, onClose, { disabled, clickTrigger });

const handleKeyUp = useEventCallback((e: KeyboardEvent) => {
if (e.keyCode === escapeKeyCode) {
if (isEscKey(e)) {
onClose(e);
}
});
Expand Down
4 changes: 4 additions & 0 deletions src/utils.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
/* eslint-disable import/prefer-default-export */
export function isEscKey(e: KeyboardEvent) {
return e.code === 'Escape' || e.keyCode === 27;
}
9 changes: 6 additions & 3 deletions test/ModalSpec.js
Original file line number Diff line number Diff line change
Expand Up @@ -158,7 +158,7 @@ describe('<Modal>', () => {

let { backdrop } = ref.current;

simulant.fire(backdrop, 'keydown', { keyCode: 27 });
simulant.fire(backdrop, 'keydown', { code: 'Escape', keyCode: 27 });
});

it('should not trigger onHide if e.preventDefault() called', () => {
Expand All @@ -176,7 +176,7 @@ describe('<Modal>', () => {

let { backdrop } = ref.current;

simulant.fire(backdrop, 'keydown', { keyCode: 27 });
simulant.fire(backdrop, 'keydown', { code: 'Escape', keyCode: 27 });
expect(onHideSpy).to.not.have.been.called;
});

Expand Down Expand Up @@ -306,7 +306,10 @@ describe('<Modal>', () => {
wrapper.setProps({ show: true });

act(() => {
simulant.fire(ref.current.backdrop, 'keydown', { keyCode: 27 });
simulant.fire(ref.current.backdrop, 'keydown', {
code: 'Escape',
keyCode: 27,
});
});

expect(onEscapeSpy).to.have.been.calledOnce;
Expand Down
12 changes: 10 additions & 2 deletions test/useRootCloseSpec.js
Original file line number Diff line number Diff line change
Expand Up @@ -158,11 +158,15 @@ describe('useRootClose', () => {

expect(spy).to.not.have.been.called;

simulant.fire(document.body, 'keyup', { keyCode: escapeKeyCode });
simulant.fire(document.body, 'keyup', {
code: 'Escape',
keyCode: escapeKeyCode,
});

expect(spy).to.have.been.calledOnce;

expect(spy.getCall(0).args.length).to.be.equal(1);
expect(spy.getCall(0).args[0].code).to.be.equal('Escape');
expect(spy.getCall(0).args[0].keyCode).to.be.equal(escapeKeyCode);
expect(spy.getCall(0).args[0].type).to.be.equal('keyup');
});
Expand All @@ -182,13 +186,17 @@ describe('useRootClose', () => {
</Wrapper>,
);

simulant.fire(document.body, 'keyup', { keyCode: escapeKeyCode });
simulant.fire(document.body, 'keyup', {
code: 'Escape',
keyCode: escapeKeyCode,
});

// TODO: Update to match expectations.
// expect(outerSpy).to.have.not.been.called;
expect(innerSpy).to.have.been.calledOnce;

expect(innerSpy.getCall(0).args.length).to.be.equal(1);
expect(innerSpy.getCall(0).args[0].code).to.be.equal('Escape');
expect(innerSpy.getCall(0).args[0].keyCode).to.be.equal(escapeKeyCode);
expect(innerSpy.getCall(0).args[0].type).to.be.equal('keyup');
});
Expand Down