Skip to content

fix: android crash on React Native 0.81 & new arch #648

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 14, 2025
Merged

fix: android crash on React Native 0.81 & new arch #648

merged 1 commit into from
Oct 14, 2025

Conversation

@war-in
Copy link
Contributor

@war-in war-in commented Sep 30, 2025 •
edited
Loading

Fixes: #647 #642

As specified in the React Native Changelog

CMake: Correctly propagate RN_SERIALIZABLE_STATE to 3rd party CMake targets. Users with custom CMake and C++ code should update to use target_compile_reactnative_options inside their CMakeLists.txt files

every lib with custom CMakeLists.tsx should use target_compile_reactnative_options since 0.81

@war-in war-in mentioned this pull request Sep 30, 2025
Closed
@williamgurzoni
Copy link

williamgurzoni commented Oct 1, 2025

This worked for our app. In fact I could replicate the situation consistently.

@mostADont
Copy link

mostADont commented Oct 1, 2025

Fixes: #647 #642

Please do not merge yet. I'll test it tomorrow and verify if it doesn't break anything. Submitting early to help other developers

Super! It works! Thank you!

@war-in war-in marked this pull request as ready for review October 1, 2025 12:48
@war-in war-in requested a review from Naturalclar as a code owner October 1, 2025 12:48
@badaz
Copy link

badaz commented Oct 4, 2025 •
edited
Loading

Worked for my app too, thanks a lot

bvoigtlaender
bvoigtlaender approved these changes Oct 7, 2025
View reviewed changes
Copy link

@bvoigtlaender bvoigtlaender left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This fixes the problem on my end as well. 👍 If its worth anything. Thank you! Hope to see it merged soon.

@DylanoHa
Copy link

DylanoHa commented Oct 13, 2025

So it has approvals... any indication of when it is merged?

@war-in
Copy link
Contributor Author

war-in commented Oct 13, 2025

I guess we're waiting for @Naturalclar to review and merge the PR 👀

@danielekbom
Copy link

danielekbom commented Oct 14, 2025

The problem has existed for more than one month now. Can we please prioritize the merge - its very critical. There are 500 000+ weekly downloads for who this package make their apps start crashing. The app crashes immediately after being on a page where this plugin is used and then navigating somewhere else. @Naturalclar thanks!

Naturalclar
Naturalclar approved these changes Oct 14, 2025
View reviewed changes
Copy link
Contributor

@Naturalclar Naturalclar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the fix!

@Naturalclar Naturalclar merged commit 5b27f9d into react-native-picker:master Oct 14, 2025
github-actions bot pushed a commit that referenced this pull request Oct 14, 2025
@semantic-release-bot
chore(release): 2.11.3 [skip ci]
b7efb65 
## [2.11.3](v2.11.2...v2.11.3) (2025-10-14)

### Bug Fixes

* android crash on React Native 0.81 & new arch ([#648](#648)) ([5b27f9d](5b27f9d))
@Naturalclar
Copy link
Contributor

Naturalclar commented Oct 14, 2025

🎉 This PR is included in version 2.11.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

@tomkelsey tomkelsey mentioned this pull request Oct 14, 2025
Closed
@iankberry iankberry mentioned this pull request Oct 15, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Naturalclar Naturalclar Naturalclar approved these changes

+2 more reviewers

@bvoigtlaender bvoigtlaender bvoigtlaender approved these changes

@DimitrisKokkonas DimitrisKokkonas DimitrisKokkonas approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

released

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Crash on Android after reload - react native 0.81

9 participants

@war-in @williamgurzoni @mostADont @badaz @DylanoHa @danielekbom @Naturalclar @bvoigtlaender @DimitrisKokkonas