fix: pass Android manifest parse errors through to the user #1270
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thymikee
force-pushed
the
fix/remove-manual-link-warnings
branch
from
c4c8d06 to
8686ca8
Compare
grabbou
reviewed
Sep 17, 2020
thymikee
force-pushed
the
fix/remove-manual-link-warnings
branch
from
8686ca8 to
75d8477
Compare
thymikee
changed the title
grabbou
approved these changes
Sep 21, 2020
Closed
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
The try/catch block in
warnAboutManuallyLinkedLibsfunctions swallowed errors when accessingconfig.projectgetter, which was the cause to the AndroidManifest parse errors not being shown to the user. There's no need for this error handling here, because if reading configuration fails, we want to know it immediately.As a bonus I've restructured the errors to not hide important things like stack trace behind dimmed text:
Fixes #1262.
Test Plan:
None, check repro.