Skip to content

chore: Migrate Android/iOS example apps to react-native-test-app #475

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 2, 2020

Conversation

tido64
Copy link
Member

@tido64 tido64 commented Oct 24, 2020

Summary:

Migrate Android and iOS example apps to react-native-test-app.

This PR became a bit bigger than anticipated because the iOS tests were randomly failing. I ended up having to bump Detox to latest version and switch to jest-circus as test runner.

See also Detox' Jest setup guide.

Test Plan:

  • Android example app should build and boot
  • iOS example app should build and boot
  • CI should pass

@tido64 tido64 force-pushed the tido/migrate-example-rnta branch 12 times, most recently from b7b26d5 to 7504de6 Compare November 1, 2020 01:45
@tido64 tido64 marked this pull request as ready for review November 1, 2020 02:08
@tido64 tido64 requested a review from krizzu November 1, 2020 02:08
@tido64 tido64 force-pushed the tido/migrate-example-rnta branch from 7504de6 to 3b94fe8 Compare November 1, 2020 21:22
Copy link
Member

@krizzu krizzu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fantastic 👏 Let's merge the other PR first, then that one

@tido64 tido64 force-pushed the tido/migrate-example-rnta branch from 3b94fe8 to 16ec497 Compare November 2, 2020 21:01
@tido64 tido64 merged commit bd2c08d into master Nov 2, 2020
@tido64 tido64 deleted the tido/migrate-example-rnta branch November 2, 2020 21:33
@krizzu
Copy link
Member

krizzu commented Jan 18, 2021

🎉 This PR is included in version 1.13.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants