chore: Bump RN to 0.62 #467
Conversation
tido64
force-pushed
the
tido/fixup-old-refs
branch
from
afdb129 to
816a7f4
Compare
tido64
force-pushed
the
tido/bump-rn-62
branch
from
bc3b852 to
479fcc4
Compare
tido64
force-pushed
the
tido/bump-rn-62
branch
3 times, most recently
from
7ee0ae5 to
0fbc2df
Compare
tido64
force-pushed
the
tido/bump-rn-62
branch
from
fc84e54 to
ffd1989
Compare
krizzu
left a comment
krizzu
left a comment
There was a problem hiding this comment.
Fantastic work 🎉 I'm glad for react-native-test-app integration!
Let's address web in follow up PR, like you proposed. I have an idea how to fix it.
Also, I know what happened to the formatting - upgrading to latest community eslint config. That version includes Prettier 2.0.2 dependency, which included a change that generates a lot of churn in codebases, without an option to disable.
I think it's ugly, but nothing we can here. We can, however, disable adding brackets in arrow functions - could you add another entry to .prettierrc? 🙏
+ "arrowParens": "avoid"
It's only integrated for macOS example app. I'll try to migrate the other platforms as well.
I'd rather not have a const single = (value) => value;
const pair = (x, y) => [x, y];The whole point of Prettier is to avoid these discussions. I think we should use the defaults. |
tido64
force-pushed
the
tido/bump-rn-62
branch
from
a699921 to
d2a06f6
Compare
We only bump to 0.62 because react-native-macos 0.63 isn't out yet. To simplify our lives, we stay in sync to avoid any potential issues from having both 0.62 and 0.63 installed.
tido64
force-pushed
the
tido/bump-rn-62
branch
from
d2a06f6 to
7a5d3da
Compare
tido64
force-pushed
the
tido/bump-rn-62
branch
from
7a5d3da to
d2a2811
Compare
|
Let's go with the defaults then, like you suggested. |
* chore: Bump RN to 0.62 We only bump to 0.62 because react-native-macos 0.63 isn't out yet. To simplify our lives, we stay in sync to avoid any potential issues from having both 0.62 and 0.63 installed. * chore(Windows): Remove workaround causing crash on 0.62
* chore: Bump RN to 0.62 We only bump to 0.62 because react-native-macos 0.63 isn't out yet. To simplify our lives, we stay in sync to avoid any potential issues from having both 0.62 and 0.63 installed. * chore(Windows): Remove workaround causing crash on 0.62
|
🎉 This PR is included in version 1.13.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Summary:
Bump the example app to 0.62.
We only bump to 0.62 because react-native-macos 0.63 isn't out yet. To simplify our lives, we stay in sync to avoid any potential issues from having both 0.62 and 0.63 installed.
Test Plan:
The test app must build and boot on the following platforms:
Web(see chore: Bump RN to 0.62 #467 (comment))