Skip to content

Fix (zod) : error paths in complex unions #787 #819

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Fix (zod) : error paths in complex unions #787 #819

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
46e0ca8
fix: error paths in complex unions
paradis-f Oct 1, 2025
89932d5
fixes zod fieldError type
paradis-f Oct 1, 2025
543cbd5
Fix FiledErrors type assertion
paradis-f Oct 1, 2025
5b92f5c
Remove unnecessary type assertion
paradis-f Oct 1, 2025
663ba6f
Remove more unnecessary type assertions
paradis-f Oct 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions valibot/src/valibot.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,9 +129,7 @@ export function valibotResolver<Input extends FieldValues, Context, Output>(

// Otherwise, return resolver result with values
return {
values: resolverOptions.raw
? Object.assign({}, values)
: (result.output as FieldValues),
values: resolverOptions.raw ? Object.assign({}, values) : result.output,
errors: {},
};
};
Expand Down
3 changes: 1 addition & 2 deletions vine/src/vine.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@ import {
} from '@vinejs/vine/build/src/types';
import {
FieldError,
FieldErrors,
FieldValues,
Resolver,
appendErrors,
Expand Down Expand Up @@ -94,7 +93,7 @@ export function vineResolver<Input extends FieldValues, Context, Output>(
options.shouldUseNativeValidation && validateFieldsNatively({}, options);

return {
errors: {} as FieldErrors,
errors: {},
values: resolverOptions.raw ? Object.assign({}, values) : data,
};
} catch (error: any) {
Expand Down
9 changes: 5 additions & 4 deletions zod/src/zod.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
import { toNestErrors, validateFieldsNatively } from '@hookform/resolvers';
import {
FieldError,
FieldErrors,
FieldValues,
Resolver,
ResolverError,
Expand Down Expand Up @@ -105,7 +104,9 @@ function parseZod4Issues(

if (error.code === 'invalid_union') {
error.errors.forEach((unionError) =>
unionError.forEach((e) => zodErrors.push(e)),
unionError.forEach((e) =>
zodErrors.push({ ...e, path: [...error.path, ...e.path] }),
),
);
}

Expand Down Expand Up @@ -254,7 +255,7 @@ export function zodResolver<Input extends FieldValues, Context, Output>(
validateFieldsNatively({}, options);

return {
errors: {} as FieldErrors,
errors: {},
values: resolverOptions.raw ? Object.assign({}, values) : data,
} satisfies ResolverSuccess<Output | Input>;
} catch (error) {
Expand Down Expand Up @@ -288,7 +289,7 @@ export function zodResolver<Input extends FieldValues, Context, Output>(
validateFieldsNatively({}, options);

return {
errors: {} as FieldErrors,
errors: {},
values: resolverOptions.raw ? Object.assign({}, values) : data,
} satisfies ResolverSuccess<Output | Input>;
} catch (error) {
Expand Down