Skip to content

Fix #153 #155

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jul 11, 2022
Merged

Fix #153 #155

merged 5 commits into from
Jul 11, 2022

Conversation

@jsun969
Copy link
Collaborator

@jsun969 jsun969 commented Jul 10, 2022

fix #153

@jsun969 jsun969 changed the title refactor(example): use react-router instead of @reach/router fix #153 Jul 10, 2022
@jsun969
Copy link
Collaborator Author

jsun969 commented Jul 10, 2022

I just improve the example.. but need your help @bluebill1049

@jsun969 jsun969 requested a review from bluebill1049 July 10, 2022 02:10
@jsun969 jsun969 changed the title fix #153 [WIP] fix #153 Jul 10, 2022
@jsun969 jsun969 changed the title [WIP] fix #153 [WIP] Fix #153 Jul 10, 2022
@jsun969 jsun969 changed the title [WIP] Fix #153 Fix #153 Jul 10, 2022
@jsun969
fix(example): import devtools from folder instead of package
d1debf1 
- Don't need to build and reinstall before run example
- Support hot update
@bluebill1049
Copy link
Member

bluebill1049 commented Jul 10, 2022

I am quite busy at the moment, I won't have time to look into this shortly.

@jsun969
Copy link
Collaborator Author

jsun969 commented Jul 10, 2022

It's ok. I'll try to fix it
Don't stress about it xD

@bluebill1049
Copy link
Member

bluebill1049 commented Jul 10, 2022

thanks, @jsun969 for understanding sorry if I haven't got a chance to reply to your message or response.

@jsun969
Copy link
Collaborator Author

jsun969 commented Jul 10, 2022

@Moshyfawn xD

@jsun969 jsun969 marked this pull request as ready for review July 11, 2022 03:09
@jsun969
Copy link
Collaborator Author

jsun969 commented Jul 11, 2022

Sry, I just upgrade the rhf's version (both devtools and example to 7.33.1) and everything is fine. lol
I think our chrome extension has totally done! 🎉 @bluebill1049

cc @Moshyfawn

@jsun969
perf: set devtools not visible by default
42c733e 
- Just show a devtools icon by default
- The extension need time to initalize.
- If show the panel, it will flash and disapper
@bluebill1049
Copy link
Member

bluebill1049 commented Jul 11, 2022

That's awesome, would you be able to provide some screenshots for the extension, I have been busy but if you can provide some screenshots I can check the UI and give feedback if any.

@jsun969
Copy link
Collaborator Author

jsun969 commented Jul 11, 2022

ye, sure!
sth error in the storybook. I may fix the type problem first xD

@jsun969
Copy link
Collaborator Author

jsun969 commented Jul 11, 2022

image

@jsun969
Copy link
Collaborator Author

jsun969 commented Jul 11, 2022

I've tweeted it
https://twitter.com/jsun969/status/1546340720378015745

@bluebill1049
Copy link
Member

bluebill1049 commented Jul 11, 2022

Looks awesome! I will find time to publish the chrome extension.

bluebill1049
bluebill1049 approved these changes Jul 11, 2022
View reviewed changes
Copy link
Member

@bluebill1049 bluebill1049 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jsun969
Copy link
Collaborator Author

jsun969 commented Jul 11, 2022

thx. Can we publish this detools first?

@jsun969 jsun969 merged commit 5cf4ada into master Jul 11, 2022
@bluebill1049
Copy link
Member

bluebill1049 commented Jul 11, 2022

could you verify the beta version: 4.1.2-beta.0?

@jsun969
Copy link
Collaborator Author

jsun969 commented Jul 11, 2022

could you verify the beta version: 4.1.2-beta.0?

sure.. where to verify?

@bluebill1049
Copy link
Member

bluebill1049 commented Jul 11, 2022

in the example app use the beta version instead?

@jsun969
Copy link
Collaborator Author

jsun969 commented Jul 11, 2022

I don't understand.. which example app you mean
can we move to wechat?

@bluebill1049
Copy link
Member

bluebill1049 commented Jul 11, 2022 •
edited
Loading

i mean use this example: https://github.com/react-hook-form/devtools/blob/master/example/package.json install the beta version, to verify if it's working as expected.

@jsun969
Copy link
Collaborator Author

jsun969 commented Jul 11, 2022 •
edited
Loading

It don't need. I import it by folder

devtools/example/src/App.tsx

Lines 1 to 2 in 5cf4ada

import type { PLACEMENT } from '../../src/devTool';
import { DevTool } from '../../src/devTool';

emm.. ye I can do a local test xD

@jsun969
Copy link
Collaborator Author

jsun969 commented Jul 11, 2022

image

I think it's no problem 👍

@bluebill1049
Copy link
Member

bluebill1049 commented Jul 11, 2022

It's been shippedhttps://github.com/react-hook-form/devtools/releases/tag/v4.2.0, thanks very much @jsun969 ! I am staying away from chatting apps for a bit. it distracts me quite often(i will come back to those later on). We will ship the chrome extension in the following days.

@jsun969
Copy link
Collaborator Author

jsun969 commented Jul 11, 2022

lol! got it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bluebill1049 bluebill1049 bluebill1049 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

control._names.mount is undefined in example

3 participants

@jsun969 @bluebill1049