[BUG] the version 1.2 introduced a regression

[buenjybar]

Describe the bug
A clear and concise description of what the bug is.

When running the new version of react-dropzone: @14.3.5 link, I noticed a regression introduced in this library

🐛 This bug was introduced in this commit

The actual error is FileDrop-ky6DIxvn.js:5

TypeError: Cannot read properties of undefined (reading 'getFile')
    at FileDrop-ky6DIxvn.js:1:43484
    at Generator.next (<anonymous>)
    at FileDrop-ky6DIxvn.js:1:386
    at new Promise (<anonymous>)
    at E (FileDrop-ky6DIxvn.js:1:183)
    at FileDrop-ky6DIxvn.js:1:43435
    at async Promise.all (__/index 0)

Accordingly to the experimental documentation of DataTransferItem: getAsFileSystemHandle() method MDN

A Promise.
If the item's kind property is "file", and this item is accessed in the dragstart or drop event handlers, then the returned promise is fulfilled with a FileSystemFileHandle if the dragged item is a file or a FileSystemDirectoryHandle if the dragged item is a directory.
Otherwise, the promise fulfills with null.

The return value can be a promise or null, but the current code doesn't manage null values

Expected behavior
A clear and concise description of what you expected to happen.
This shouldn't crash at runtime

Desktop (please complete the following information):

• userAgent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/130.0.0.0 Safari/537.36

Additional context
Add any other context about the problem here.

It seems that the old/legacy behavior is working as expected.

[jonkoops]

@rolandjitsu should we set up a v1 branch so we can fix this one without creating a conflict with the beta branch?

[rolandjitsu]

That's a bug alright. Thanks @buenjybar for reporting it. @jonkoops yes, we'll need a 1.2.x branch where we cherry pick a commit from master after we make a PR to master with the same fix for v2.

Let me setup the 1.2.x branch.

[rolandjitsu]

Once #107 goes through, we'll make a bump in react-dropzone as well.

[jonkoops]

@buenjybar can you provide some details on how this can be reproduced? Which browser is being used, and in what way is the library called? Please provide a minimal code example like we have in the README.

[buenjybar]

Sure the scenario is being done in a cypress e2e tests, I will try to find the best way to reproduce this bug

[jonkoops]

Great thanks! Please make sure to provide a minimal and reproducible example that does not include any third party libraries/frameworks such as Cypress, React, etc.

[buenjybar]

you can see how to reproduce the bug here.
👉 https://github.com/buenjybar/react-dropzone-issue106/

[jonkoops]

That example still contains a bunch of framework specific code, could you provide a minimal example without React and testing frameworks and only file-selector? Here is a StackBlitz project you can use as a base.

[buenjybar]

That example still contains a bunch of framework specific code, could you provide a minimal example without React and testing frameworks and only file-selector? Here is a StackBlitz project you can use as a base.

In the code sample there is nothing sophisticated.
I have explained how to reproduce it in the README.md

$ npm install
$ npm run start
// in a different terminal
$ npm run cy:open

// on cypress
Click on "E2E Testing"
Run on Chrome v.130 (whatever)
Run the app.spec.cy.js
open the console and see the crash

TypeError: Cannot read properties of undefined (reading 'getFile')
    at FileDrop-ky6DIxvn.js:1:43484
    at Generator.next (<anonymous>)
    at FileDrop-ky6DIxvn.js:1:386
    at new Promise (<anonymous>)
    at E (FileDrop-ky6DIxvn.js:1:183)
    at FileDrop-ky6DIxvn.js:1:43435
    at async Promise.all (__/index 0)