Skip to content

feat: improve Input accessibility #1186

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zombieJ merged 1 commit into from
Dec 10, 2025
+61 −17
Merged

feat: improve Input accessibility #1186

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/SelectInput/Input.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -179,9 +179,9 @@ const Input = React.forwardRef<HTMLInputElement, InputProps>((props, ref) => {
role: role || 'combobox',
'aria-expanded': open || false,
'aria-haspopup': 'listbox' as const,
'aria-owns': `${id}_list`,
'aria-owns': open ? `${id}_list` : undefined,
'aria-autocomplete': 'list' as const,
'aria-controls': `${id}_list`,
'aria-controls': open ? `${id}_list` : undefined,
'aria-activedescendant': open ? activeDescendantId : undefined,
};

Expand Down
58 changes: 58 additions & 0 deletions tests/Accessibility.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -214,4 +214,62 @@ describe('Select.Accessibility', () => {
});
});
});

describe('Select Input attributes', () => {
it('should have correct aria and role attributes by default', () => {
const { container } = render(
<Select
options={[
{
value: '123',
},
{
value: '1234',
},
{
value: '12345',
},
]}
/>,
);

const input = container.querySelector('input');
expect(input).toHaveAttribute('role', 'combobox');
expect(input).toHaveAttribute('aria-expanded', 'false');
expect(input).toHaveAttribute('aria-haspopup', 'listbox');
expect(input).not.toHaveAttribute('aria-owns');
expect(input).toHaveAttribute('aria-autocomplete', 'list');
expect(input).not.toHaveAttribute('aria-controls');
expect(input).not.toHaveAttribute('aria-activedescendant');
});

it('should have correct aria and role attributes when open', () => {
const { container } = render(
<Select
id="select"
open
options={[
{
value: '123',
},
{
value: '1234',
},
{
value: '12345',
},
]}
/>,
);

const input = container.querySelector('input');
expect(input).toHaveAttribute('role', 'combobox');
expect(input).toHaveAttribute('aria-expanded', 'true');
expect(input).toHaveAttribute('aria-haspopup', 'listbox');
expect(input).toHaveAttribute('aria-owns', 'select_list');
expect(input).toHaveAttribute('aria-autocomplete', 'list');
expect(input).toHaveAttribute('aria-controls', 'select_list');
expect(input).toHaveAttribute('aria-activedescendant', 'select_list_0');
});
});
Comment on lines +218 to +274
Copy link

@gemini-code-assist gemini-code-assist bot Dec 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

To improve maintainability and reduce code duplication, you can extract the options array, which is identical in both test cases, into a constant defined at the top of the describe block.

  describe('Select Input attributes', () => {
    const options = [
      {
        value: '123',
      },
      {
        value: '1234',
      },
      {
        value: '12345',
      },
    ];

    it('should have correct aria and role attributes by default', () => {
      const { container } = render(
        <Select
          options={options}
        />,
      );

      const input = container.querySelector('input');
      expect(input).toHaveAttribute('role', 'combobox');
      expect(input).toHaveAttribute('aria-expanded', 'false');
      expect(input).toHaveAttribute('aria-haspopup', 'listbox');
      expect(input).not.toHaveAttribute('aria-owns');
      expect(input).toHaveAttribute('aria-autocomplete', 'list');
      expect(input).not.toHaveAttribute('aria-controls');
      expect(input).not.toHaveAttribute('aria-activedescendant');
    });

    it('should have correct aria and role attributes when open', () => {
      const { container } = render(
        <Select
          id="select"
          open
          options={options}
        />,
      );

      const input = container.querySelector('input');
      expect(input).toHaveAttribute('role', 'combobox');
      expect(input).toHaveAttribute('aria-expanded', 'true');
      expect(input).toHaveAttribute('aria-haspopup', 'listbox');
      expect(input).toHaveAttribute('aria-owns', 'select_list');
      expect(input).toHaveAttribute('aria-autocomplete', 'list');
      expect(input).toHaveAttribute('aria-controls', 'select_list');
      expect(input).toHaveAttribute('aria-activedescendant', 'select_list_0');
    });
  });

});
4 changes: 0 additions & 4 deletions tests/__snapshots__/Combobox.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,10 +15,8 @@ exports[`Select.Combobox renders controlled correctly 1`] = `
</div>
<input
aria-autocomplete="list"
aria-controls="test-id_list"
aria-expanded="false"
aria-haspopup="listbox"
aria-owns="test-id_list"
autocomplete="off"
class="rc-select-input"
id="test-id"
Expand All @@ -45,10 +43,8 @@ exports[`Select.Combobox renders correctly 1`] = `
</div>
<input
aria-autocomplete="list"
aria-controls="test-id_list"
aria-expanded="false"
aria-haspopup="listbox"
aria-owns="test-id_list"
autocomplete="off"
class="rc-select-input"
id="test-id"
Expand Down
10 changes: 0 additions & 10 deletions tests/__snapshots__/Select.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,12 +124,10 @@ exports[`Select.Basic render renders aria-attributes correctly 1`] = `
</div>
<input
aria-autocomplete="list"
aria-controls="test-id_list"
aria-expanded="false"
aria-haspopup="listbox"
aria-label="some-label"
aria-labelledby="test-id"
aria-owns="test-id_list"
autocomplete="off"
class="antd-input"
id="test-id"
Expand Down Expand Up @@ -162,10 +160,8 @@ exports[`Select.Basic render renders correctly 1`] = `
</div>
<input
aria-autocomplete="list"
aria-controls="test-id_list"
aria-expanded="false"
aria-haspopup="listbox"
aria-owns="test-id_list"
autocomplete="off"
class="antd-input"
id="test-id"
Expand Down Expand Up @@ -200,10 +196,8 @@ exports[`Select.Basic render renders data-attributes correctly 1`] = `
</div>
<input
aria-autocomplete="list"
aria-controls="test-id_list"
aria-expanded="false"
aria-haspopup="listbox"
aria-owns="test-id_list"
autocomplete="off"
class="antd-input"
id="test-id"
Expand Down Expand Up @@ -236,10 +230,8 @@ exports[`Select.Basic render renders disabled select correctly 1`] = `
</div>
<input
aria-autocomplete="list"
aria-controls="test-id_list"
aria-expanded="false"
aria-haspopup="listbox"
aria-owns="test-id_list"
autocomplete="off"
class="antd-input"
disabled=""
Expand Down Expand Up @@ -271,10 +263,8 @@ exports[`Select.Basic render renders role prop correctly 1`] = `
</div>
<input
aria-autocomplete="list"
aria-controls="test-id_list"
aria-expanded="false"
aria-haspopup="listbox"
aria-owns="test-id_list"
autocomplete="off"
class="antd-input"
id="test-id"
Expand Down
2 changes: 1 addition & 1 deletion tests/__snapshots__/ssr.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
// Jest Snapshot v1, https://goo.gl/fbAQLP

exports[`Select.SSR should work 1`] = `"<div class="rc-select rc-select-single"><div class="rc-select-content"><div class="rc-select-placeholder" style="visibility:visible"></div><input id="test-id" type="search" readonly="" autoComplete="off" class="rc-select-input" role="combobox" aria-expanded="false" aria-haspopup="listbox" aria-owns="test-id_list" aria-autocomplete="list" aria-controls="test-id_list" value=""/></div></div>"`;
exports[`Select.SSR should work 1`] = `"<div class="rc-select rc-select-single"><div class="rc-select-content"><div class="rc-select-placeholder" style="visibility:visible"></div><input id="test-id" type="search" readonly="" autoComplete="off" class="rc-select-input" role="combobox" aria-expanded="false" aria-haspopup="listbox" aria-autocomplete="list" value=""/></div></div>"`;
Loading