fix: getValueProps should not be executed when name does not exist
#666
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
jongwong
reviewed
Mar 20, 2024
| <div> | ||
| <Form initialValues={{ test: 'bamboo' }}> | ||
| <Field getValueProps={getValueProps}> | ||
| <span className="anything" /> |
There was a problem hiding this comment.
lack of case when children is a function.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #666 +/- ##
=======================================
Coverage 99.43% 99.43%
=======================================
Files 18 18
Lines 1247 1247
Branches 288 308 +20
=======================================
Hits 1240 1240
Misses 7 7 ☔ View full report in Codecov by Sentry. |
zombieJ
reviewed
Mar 26, 2024
zombieJ
reviewed
Mar 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref: ant-design/ant-design#47952