feat: validate support dirty #625
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
crazyair
reviewed
Oct 17, 2023
| export async function waitFakeTime(timeout: number = 10) { | ||
| await act(async () => { | ||
| await Promise.resolve(); | ||
| jest.advanceTimersByTime(timeout); |
There was a problem hiding this comment.
await 加到这里也可以吧？不需要 Promise.resolve
There was a problem hiding this comment.
jest.advanceTimersByTime 不是 async 函数，加了 await 会报错。
There was a problem hiding this comment.
明白，但是可以加。加了反而还有作用，不加反倒 test 会挂
Codecov Report
@@ Coverage Diff @@
## master #625 +/- ##
=======================================
Coverage 99.43% 99.43%
=======================================
Files 18 18
Lines 1229 1236 +7
Branches 282 283 +1
=======================================
+ Hits 1222 1229 +7
Misses 7 7
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
crazyair
reviewed
Oct 17, 2023
| <InfoField name="validate" rules={[{ required: true, message: validateMessage }]}> | ||
| <Input /> | ||
| </InfoField> | ||
| <InfoField name="noop" rules={[{ required: true, message: 'noop' }]}> |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref ant-design/ant-design#42347